Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: ipfs2 config --show is not functional. switch to ipfs config show? #310

Closed
btc opened this issue Nov 12, 2014 · 1 comment
Closed
Assignees

Comments

@btc
Copy link
Contributor

btc commented Nov 12, 2014

#263 changes ipfs2 config --show to ipfs2 config show.

Previously, --show was used to avoid collisions with a key named show. Recall: ipfs config <key> is used to lookup keys.

Three potential ways to proceed:

  1. Allow ipfs2 config show with the awareness that we introduce potential for collision. While, in most cases, this will not be a problem, it is a poor compromise.

  2. Allow ipfs2 config show and change ipfs2 config <key> to ipfs2 config get <key>. This avoids the collision, requires sign-off.

  3. Adapt the commands framework to handle this use-case as desired. (edit: by making them options on the super command)

edit: We decided to do away with the config subcommands make --show and --edit options in the super command.

@btc btc added this to the merge commands milestone Nov 12, 2014
@btc btc self-assigned this Nov 12, 2014
@btc btc changed the title cli: ipfs2 config --show is not functional. switch to ipfs config show cli: ipfs2 config --show is not functional. switch to ipfs config show? Nov 12, 2014
@btc
Copy link
Contributor Author

btc commented Nov 12, 2014

@jbenet @mappum have we come to agreement on how to address this command?

edit: I see on the spreadsheet that jbenet is covering it.

https://docs.google.com/a/perfmode.com/spreadsheets/d/1XgSDZGTSIrgdO48lLzUKLYTzZHk-ggW9RMJm2U-nrLs/edit#gid=0

@btc btc assigned jbenet and mappum and unassigned btc and jbenet Nov 12, 2014
@btc btc closed this as completed Nov 13, 2014
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants