Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: set ipfs2 diag net default encoding to text #319

Closed
1 task done
btc opened this issue Nov 13, 2014 · 1 comment
Closed
1 task done

cli: set ipfs2 diag net default encoding to text #319

btc opened this issue Nov 13, 2014 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@btc
Copy link
Contributor

btc commented Nov 13, 2014

Discovered that ipfs2 diag net defaults to json output. ipfs net-diag displays plaintext output. Switch default to plaintext.

  • add plaintext marshaller for net diagnostics
@btc btc added the kind/bug A bug in existing code (including security flaws) label Nov 13, 2014
@btc btc added this to the merge-commands milestone Nov 13, 2014
@btc btc changed the title cli: set ipfs2 diag net default encoding to json cli: set ipfs2 diag net default encoding to test Nov 13, 2014
@btc btc changed the title cli: set ipfs2 diag net default encoding to test cli: set ipfs2 diag net default encoding to text Nov 13, 2014
@btc
Copy link
Contributor Author

btc commented Nov 13, 2014

fixed in 4b625b2

@btc btc closed this as completed Nov 13, 2014
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
Fix some provider subsystem performance issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

1 participant