Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition: use of "range + closure + goroutine" combination #40

Closed
btc opened this issue Sep 11, 2014 · 2 comments
Closed

Race condition: use of "range + closure + goroutine" combination #40

btc opened this issue Sep 11, 2014 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@btc
Copy link
Contributor

btc commented Sep 11, 2014

bug located at: https://github.com/jbenet/go-ipfs/blob/7968b45e58e6dfee3e732276a6cb7eab889a4333/bitswap/bitswap.go#L182

see: https://code.google.com/p/go-wiki/wiki/CommonMistakes#Using_Closures_with_Goroutines
@btc btc added the kind/bug A bug in existing code (including security flaws) label Sep 11, 2014
@whyrusleeping
Copy link
Member

There is no bug here, the code in question is correct, and the variables are properly captured by the closure.

@btc
Copy link
Contributor Author

btc commented Sep 11, 2014

You're right.

@btc btc closed this as completed Sep 11, 2014
@ghost ghost mentioned this issue Sep 20, 2016
Closed
ribasushi pushed a commit that referenced this issue Jul 4, 2021
@Stebalien
rename the protobuf to loggabletracer
dbdd6a1 
Also, regenerate with the latest gogo protobuf package.

fixes #40
longfeiWan9 pushed a commit to longfeiWan9/go-ipfs that referenced this issue Nov 18, 2021
@jessicaschilling
Merge pull request ipfs#40 from ipfs/feat/add-build-script
9603194 
feat: Build script
@ajnavarro ajnavarro mentioned this issue Aug 24, 2022
Closed
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@btc @whyrusleeping