Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs resolve isn't behaving well #5703

Closed
Stebalien opened this issue Oct 30, 2018 · 1 comment · Fixed by #5704
Closed

ipfs resolve isn't behaving well #5703

Stebalien opened this issue Oct 30, 2018 · 1 comment · Fixed by #5704
Assignees
@Stebalien

Comments

@Stebalien
Copy link
Member

From the interface-ipfs-core tests,

CID=$(ipfs dag put <<<'{"path": {"to": {"file": "asdfasdfasdf"}}}')
ipfs resolve /ipfs/$CID/path/to/file

should fail with "found non-link at given path".

Currently, it returns /ipfs/$CID.

Really, it should fail with "not a valid unixfs file". However, if we replace /ipfs with /ipld, it still returns the same result. In that case, it should probably just return the entire path (IMO, it shouldn't error).

However, neither of these fixes will make the JS tests pass.
@Stebalien
Copy link
Member Author

See: ipfs-inactive/interface-js-ipfs-core#385

Stebalien added a commit that referenced this issue Oct 30, 2018
@Stebalien
fix: return the shortest, completely resolved path in the resolve com…
a26bf59 
…mand

fixes #5703

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien mentioned this issue Oct 30, 2018
Merged
@ghost ghost assigned Stebalien Oct 30, 2018
@ghost ghost added the status/in-progress In progress label Oct 30, 2018
Stebalien added a commit that referenced this issue Nov 13, 2018
@Stebalien
fix: return the shortest, completely resolved path in the resolve com…
13ca9f4 
…mand

fixes #5703

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jan 23, 2019
@Stebalien
fix: return the shortest, completely resolved path in the resolve com…
ff87d4a 
…mand

fixes #5703

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jan 23, 2019
@Stebalien
fix: return the shortest, completely resolved path in the resolve com…
1f11184 
…mand

fixes #5703

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jan 23, 2019
@Stebalien
fix: return the shortest, completely resolved path in the resolve com…
4fe3a72 
…mand

fixes #5703

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@magik6k magik6k mentioned this issue Feb 14, 2019
Open
Stebalien added a commit that referenced this issue Feb 19, 2019
@Stebalien
fix: return the shortest, completely resolved path in the resolve com…
082dcda 
…mand

fixes #5703

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Feb 19, 2019
@Stebalien
fix: return the shortest, completely resolved path in the resolve com…
4bb1cb6 
…mand

fixes #5703

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost removed the status/in-progress In progress label Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: return the shortest, completely resolved path in the resolve command ipfs/kubo
1 participant
@Stebalien