Install issue

[fedor-shi]

Version information:

Software:

    System Software Overview:

      System Version: macOS 10.13.6 (17G65)
      Kernel Version: Darwin 17.7.0
      Boot Volume: Macintosh HD
      Boot Mode: Normal

$ go version
go version go1.11.1 darwin/amd64

Type:

Bug

Description:

Get the error, when try to install

make install
bin/check_go_version 1.11
fatal: 'go version' failed with output: go: parsing $GOFLAGS: non-flag "\"github.com/ipfs/go-ipfs\".CurrentCommit=3f7668bdc\""
make: *** [check_go_version] Error 1

executed from

 $pwd
/Users/theodor/go/src/github.com/ipfs/go-ipfs

 ~/go/src/github.com/ipfs/go-ipfs   master                                                                                                                                                                            ✔  1294  11:51:59
 $ echo $GOPATH
/Users/theodor/go

[eingenito]

I don't know a ton about the build process, but it seems like you're picking up some crud in your GOFLAGS environment variable that's blowing up the call to bin/check_go_version. I don't know how our build uses (or might populate) GOFLAGS, but if you just do echo $GOFLAGS is there anything in there? If you run bin/check_go_version 1.11 in the go-ipfs directory what does it explode? I'll take a look at the makefiles and see if I can figure out how it might have set that variables in a bad way.

[fedor-shi]

@eingenito you are right
I have

echo $GOFLAGS
-ldflags=-compressdwarf=false

and it breaks the build. It works for me in a such way make install GOFLAGS=

[Stebalien]

Does #5747 also fix your issue? We shouldn't be failing in this case regardless.

[fedor-shi]

@Stebalien I tested it, works with fix