Docker built go-ipfs fails to report its commit version

[olizilla]

Versions of go-ipfs built via our Dockerfile are unable to report their commit version, as initially reported by @gmasgras

To see this in action you can try out the go-ipfs:latest image and ask it for ipfs version --commit

$ docker run -d --name ipfs_host -v $ipfs_staging:/export -v $ipfs_data:/data/ipfs -p 4001:4001 -p 127.0.0.1:8080:8080 -p 127.0.0.1:5001:5001 ipfs/go-ipfs:latest

$ docker exec ipfs_host ipfs version --commit
ipfs version 0.4.22-

The output of the ipfs verison command should be the same when docker is used to build it.

We use docker built go-ipfs versions on the gateway and not being able to ask them for their commit will make reporting issues harder.

[olizilla]

Some old prior art on this issue #2734

[olizilla]

Looks like CI tests for this got disabled some time ago in this commit c103efc as part of the move to gx #2256

[gmasgras]

more context from https://github.com/protocol/bifrost-infra/issues/170#issuecomment-525930434

This is likely because we don't copy .git/objects) in the Docker build context.
see:
https://github.com/ipfs/go-ipfs/blob/master/cmd/ipfs/Rules.mk#L16
https://github.com/ipfs/go-ipfs/blob/master/mk/git.mk#L1
https://github.com/ipfs/go-ipfs/blob/master/.dockerignore#L3)

[Stebalien]

Ah. This was broken in c8c0c48.

[Stebalien]

Should be fixed in #6626.

[olizilla]

@Stebalien this is happening again on master... neither the version command nor the prometheus stats for ipfs_info are reporting the current commit for the docker build

$ docker run --name ipfs-master ipfs/go-ipfs:master
# new shell
$ docker exec ipfs-master ipfs version --commit
ipfs version 0.5.0-dev

[olizilla]

the rc is ok tho

$ docker run --name ipfs-rc ipfs/go-ipfs:v0.4.23-rc1
Unable to find image 'ipfs/go-ipfs:v0.4.23-rc1' locally
v0.4.23-rc1: Pulling from ipfs/go-ipfs

# new shell
$ docker exec ipfs-rc ipfs version --commit
ipfs version 0.4.23-rc1-c81bcc0

[Stebalien]

Hm. Apparently, "append" is completely ignored when overridden in the command. I'm switching it to GOTAGS.