Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

startup errors are ugly #6651

Closed
Stebalien opened this issue Sep 19, 2019 · 1 comment · Fixed by #8638
Closed

startup errors are ugly #6651

Stebalien opened this issue Sep 19, 2019 · 1 comment · Fixed by #8638
Assignees
@schomatis
Labels
kind/bug A bug in existing code (including security flaws)
Milestone
Best Effort Track

Comments

@Stebalien
Copy link
Member

Errors produced by fx on startup are really ugly. See #6650.

We should just strip the rest of the error when reporting it to the user.
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Sep 19, 2019
@Stebalien Stebalien mentioned this issue Sep 19, 2019
Closed
@schomatis schomatis mentioned this issue Dec 23, 2021
Closed
@schomatis
Copy link
Contributor

Not really sure how to fix this but my dislike for fx errors pushes me to give this a try at least.

@schomatis schomatis self-assigned this Dec 23, 2021
@schomatis schomatis mentioned this issue Jan 5, 2022
Merged
@BigLep BigLep moved this to 🔎 In Review in IPFS Shipyard Team Mar 10, 2022
@BigLep BigLep added this to the Best Effort Track milestone Mar 10, 2022
Repository owner moved this from 🔎 In Review to ✅ Done in IPFS Shipyard Team Mar 16, 2022
@BigLep BigLep moved this from 🎉 Done to ☑️ Done (Archive) in IPFS Shipyard Team Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schomatis schomatis

Labels
kind/bug A bug in existing code (including security flaws)
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
Best Effort Track
Development

Successfully merging a pull request may close this issue.

fix(core/node): unwrap fx error in node construction ipfs/kubo
3 participants
@BigLep @Stebalien @schomatis