Config nodes to listen on QUIC by default

[momack2]

• change the default config to listen on quic by default quic: remove experimental status and add it to the default config #7349
• upgrade bootstrappers to listen on quic https://github.com/protocol/bifrost-infra/issues/778
• add a migration to feat: migration 9 to 10 fs-repo-migrations#102
  • listen on quic on existing TCP listen addresses
  • add quic addresses for the bootstrappers

[RubenKelevra]

QUIC is still experimental, I feel like this should be done when QUIC is considered stable. :)

[aschmahmann]

@RubenKelevra the plan is to make QUIC non-experimental and supported by default. In order to do that this issue needs to be tackled.

[RubenKelevra]

@RubenKelevra the plan is to make QUIC non-experimental and supported by default. In order to do that this issue needs to be tackled.

Yeah. I've just tested it. The daemon will start happily with the definition but quic disabled.

So there's no blocker for this, regardless if QUIC is stable or not.

Currently I'm experiencing memory leaks with QUIC on, while not all fixes for this (as far as I understand) are in the master.

See #7263

[dirkmc]

Should the reverse migration always set Experimental.QUIC to false?
This could be surprising to someone who

• has Experimental.QUIC set to true
• migrates forwards
• migrates backwards
• Experimental.QUIC is now false

[RubenKelevra]

Should the reverse migration always set Experimental.QUIC to false?
This could be surprising to someone who

• has Experimental.QUIC set to true
• migrates forwards
• migrates backwards
• Experimental.QUIC is now false

I don't think we should enable experimental options on the migration.

As far as I understand the idea is to enable the listening entries for QUIC on the migration and add the QUIC addresses for the bootstrappers. When QUIC is stable, the experimental option will be removed and it will be on by default.

[dirkmc]

Right, of course, that makes sense :)

[Stebalien]

@dirkmc

The idea is to:

1. Drop the experimental feature flag and enable it by default. The migration doesn't have to handle that.
2. Have a migration that adds the listen address. The reverse migration shouldn't do anything.

So yeah, the reverse migration may be a bit surprising, but it won't be the end of the world. At worst, we'll end up disabling the QUIC transport.

[Stebalien]

Complete feature description:

1. No reverse migration.
2. On the forward migration:
   1. Add a QUIC bootstrap address for mars.
   2. For every /tcp/PORT swarm listen address, add a /udp/PORT/quic listen address.
   3. For every /tcp/PORT address in Announce/NoAnnounce, add a /udp/PORT/quic address.