Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change usage of Multiaddrs away from pointers. #81

Closed
whyrusleeping opened this issue Sep 15, 2014 · 3 comments
Closed

Change usage of Multiaddrs away from pointers. #81

whyrusleeping opened this issue Sep 15, 2014 · 3 comments
Labels
help wanted Seeking public contribution on this issue

Comments

@whyrusleeping
Copy link
Member

We are using pointers to multiaddrs in quite a few places, its pretty redundant to do so since they are just byte arrays, i feel that fixing this will clean up a good deal of code.
@btc
Copy link
Contributor

btc commented Sep 15, 2014

+1

reducing the use of pointers everywhere possible!

@btc
Copy link
Contributor

btc commented Sep 15, 2014

Though...

Right now, we need to bit a bit careful about making sweeping changes since there are still some significant merges that will need to take place. ie. net, ipns, master

@btc btc added the help wanted Seeking public contribution on this issue label Sep 16, 2014
@jbenet
Copy link
Member

jbenet commented Nov 4, 2014

Multiaddrs are now interfaces.

@jbenet jbenet closed this as completed Nov 4, 2014
@Stebalien Stebalien mentioned this issue May 26, 2020
Closed
77 tasks
@aschmahmann aschmahmann mentioned this issue Sep 22, 2020
Closed
72 tasks
ribasushi pushed a commit that referenced this issue Jul 4, 2021
@Stebalien
Merge pull request #81 from maoxs2/master
2f9b338 
Add avaliable but "Deprecated"-tagged  Warning/Warningf func for compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbenet @btc @whyrusleeping