-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Gateway HTTP request metrics #8441
Comments
Include block and car in unixfs_get_latency_seconds for now, so we keep basic visibility into gateway behavior until better metrics are added by #8441
Regarding the set of buckets, what is the reasoning behind these values? I would suggest 50ms, 100ms, 250ms, 500ms, 1s, 2s, 5s, 10s. This is still arbitrary, but I feel it could capture more information. |
My reasoning for most of the values is that it's common to see buckets using the Fibonacci sequence. 30s and 60s are personal preference + they align with some of our timeouts on the gateways. |
Wishlist
from @gmasgras
sum
andcount
metrics are exported. It would be very useful to also export this metric as a histogram (egunixfs_get_latency_seconds_bucket
) so that we can calculate percentiles (p90, p95) and get a better understanding of outliers. A good set of buckets could be 100ms, 500ms, 1s, 2s, 3s, 5s, 8s, 13sfrom @lidel
low utility, we care about first content blockgw_first_root_block_get_latency_seconds
with time to return the root block –/ipfs/{cid}
,/ipns/{example.com}
gw_first_content_block_get_latency_seconds
with time to first content block of specific resource –/ipfs/{cid}/some/file.jpg
The text was updated successfully, but these errors were encountered: