Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move off CircleCI to GitHub Actions #8804

Closed
BigLep opened this issue Mar 19, 2022 · 7 comments
Closed

Move off CircleCI to GitHub Actions #8804

BigLep opened this issue Mar 19, 2022 · 7 comments
Assignees
Labels
team/ipdx Notify IP Developer Experience team
Milestone

Comments

@BigLep
Copy link
Contributor

BigLep commented Mar 19, 2022

Done Criteria

Integration tests run from GitHub actions rather than GitHub Actions

Why Important

  1. CircleCI becomes one more piece of infrastructure we need to manage and be aware of
  2. Most everything else has moved to GitHub actions. Relates to the above. Narrow the toolchain and have consistency.
  3. Makes it easier for forks to run tests

User/Customer

Contributors and maintainers

Notes

@BigLep BigLep added this to the TBD milestone Mar 19, 2022
@BigLep
Copy link
Contributor Author

BigLep commented Mar 19, 2022

Another added benefit is we should get better test output for debugging test failures. Copied in discussion about CircleCI from Discord.

From @lidel about what we have to do in CircleCI:

you can get the name of sharness test file from sharnessLinux.t0043-add-w  → then you run that specific test locally, in debug mode  ./t0043-add-w.sh -v 

if the output does not tell you much, add && cat actual && cat expected &&   in the middle  scripts to print  compared values.

Not sure if there is a better way, but thats what I've been doing.

@guseggert
Copy link
Contributor

We'd need to setup self-hosted runners for this, as we use the 2xlarge CircleCI resource class which is 16 vCPUs and 32 GB RAM, whereas GH Actions hosted runners only provide 2 vCPUs and 7 GB RAM, which would slow down the build time by an unacceptable amount.

@galargh galargh added the team/ipdx Notify IP Developer Experience team label Sep 13, 2022
@galargh
Copy link
Contributor

galargh commented Sep 19, 2022

Current status: I managed to successfully run all the workflows from CircleCI in GitHub Actions. Tracked in https://github.com/galargh/go-ipfs/tree/github-actions

Next steps: set up self-hosted runners to boost performance. 30m+ builds are not acceptable.

@galargh
Copy link
Contributor

galargh commented Oct 20, 2022

Rollout plan:

  • Merge PR introducing new GitHub Actions workflows that are to replace the CircleCI ones (PR)
  • Verify the new wokflows running on GitHub-hosted machines are no-worse than the CircleCI ones (~1 or 2 weeks after the initial merge), remove the [EXPERIMENTAL] label from them and remove the obsolete CircleCI jobs
  • Verify the new wokflows running on self-hosted machines are no-worse than the CircleCI ones (~1 month after the initial merge), remove the [EXPERIMENTAL] label from them and remove the obsolete CircleCI jobs

@BigLep
Copy link
Contributor Author

BigLep commented Apr 6, 2023

@galargh : I see circle ci mentioned in https://github.com/ipfs/kubo/blob/master/docs/RELEASE_ISSUE_TEMPLATE.md . Is that getting removed in a PR somewhere?

@galargh
Copy link
Contributor

galargh commented Apr 6, 2023

@BigLep not as part of this issue as it's only mentioned in the context of CI setups in ipfs-distributions and ipfs-docs. It should be easier to migrate these two to GHA though. We could look into it after IPFS Thing.

@BigLep
Copy link
Contributor Author

BigLep commented Apr 6, 2023

Ack - make sense - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/ipdx Notify IP Developer Experience team
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants