Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bitswap) ensure one active request per key #95

Closed
btc opened this issue Sep 22, 2014 · 3 comments
Closed

feat(bitswap) ensure one active request per key #95

btc opened this issue Sep 22, 2014 · 3 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@btc
Copy link
Contributor

btc commented Sep 22, 2014

Presently, for a key |k|, concurrent calls to bitswap.GetBlock(k) result in multiple requests (get providers then fan out and get blocks).

Need to ensure only one active request per key.

In-progress.
@btc btc added kind/enhancement A net-new feature or improvement to an existing feature status/in-progress In progress labels Sep 22, 2014
@btc btc self-assigned this Sep 22, 2014
@btc btc mentioned this issue Sep 22, 2014
Closed
@btc btc added ready and removed status/in-progress In progress labels Sep 23, 2014
@btc btc removed the ready label Nov 24, 2014
@btc
Copy link
Contributor Author

btc commented Dec 8, 2014

@jbenet @whyrusleeping This issue may be irrelevant given the new architecture. Shall we close?

@btc btc removed their assignment Dec 8, 2014
@jbenet
Copy link
Member

jbenet commented Dec 9, 2014

@maybebtc i think you're right. @whyrusleeping ?

@whyrusleeping
Copy link
Member

Yeah, this is irrelevant with the way bitswap works now

@aschmahmann aschmahmann mentioned this issue Sep 22, 2020
Closed
72 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@whyrusleeping
Merge pull request ipfs#95 from libp2p/feat/conn-tagging
afa8222 
tag kbucket peers for better connection closing
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
Merge pull request ipfs#95 from ipfs/fix/key-init-message
463d28f 
fix: include key size in key init method
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
go-ipfs-config: Merge pull request ipfs#95 from ipfs/fix/key-init-mes…
81af2c2 
…sage

fix: include key size in key init method
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Mar 4, 2022
@Stebalien
go-ipfs-config: Merge pull request ipfs#95 from ipfs/fix/key-init-mes…
5fb1268 
…sage

fix: include key size in key init method
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Mar 4, 2022
@Stebalien
go-ipfs-config: Merge pull request ipfs#95 from ipfs/fix/key-init-mes…
435b942 
…sage

fix: include key size in key init method
hacdias added a commit that referenced this issue Nov 29, 2023
@hacdias
feat: add UseCumulativeSize UnixfsLs option (#95)
ccbe8aa 
This commit was moved from ipfs/interface-go-ipfs-core@b1299ab

This commit was moved from ipfs/boxo@ff2eb2b
hacdias added a commit that referenced this issue Nov 29, 2023
@hacdias
feat: add UseCumulativeSize UnixfsLs option (#95)
d2edb2e 
This commit was moved from ipfs/interface-go-ipfs-core@b1299ab

This commit was moved from ipfs/boxo@ff2eb2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbenet @btc @whyrusleeping