-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Routing.Type=auto from enabling dhtserver mode if have too low of limits #9548
Comments
@Jorropo this will be only applied when custom I assume we don't want to apply this to people running with the implicit defaults, otherwise many current DHT servers like mine will disappear when they updade, causing higher load on remaining DHT servers. Example: I run my Have 32GB RAM and {
"Conns": 1000000000,
"ConnsInbound": 558,
"ConnsOutbound": 1000000000,
"FD": 524288,
"Memory": 8300000000,
"Streams": 1000000000,
"StreamsInbound": 8939,
"StreamsOutbound": 1000000000
} |
@ajnavarro : per 2023-01-17 standup, base your work on #9555 |
…not using none connmgr Fixes: ipfs#9548
…not using none connmgr Fixes: ipfs#9548
…not using none connmgr Fixes: ipfs#9548
…oo low of limits Closes #9548 Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
…oo low of limits Closes #9548 Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
…oo low of limits Closes #9548 Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Wrong comment on commit |
Done Criteria
A Kubo node with
Routing.Type=auto
doesn't attempt to be a DHT server if the following additional conditions aren't met:(Existing logic of ensuring the node is publicly dialable will still apply.)
Why Important
If a "dhtserver" node advertises itself to the DHT but has too-low of hard Swarm.ResourceMgr limits, then it won't be able to function and be of value to the DHT and instead degrades performance.
Notes
Swarm.ResourceMgr.System.StreamsInbound
in addition toSwarm.ResourceMgr.System.Streamsnbound
The text was updated successfully, but these errors were encountered: