-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start API on both IPv4 and IPv6 #9637
Comments
It's localhost, I don't belive this is an issue. It's still intresting to solve just because we would need to make |
It does cause issues since Node.js uses IPv6 for localhost by default (dns is verbatim from os, not reordered to have IPv4 at the start) from version 18 onward. It would be helpful for Kubo to listen on both stacks to ensure that doesn't cause problems for anyone else like it did for me. |
I'm surprised that nodejs does this, ¯\_(ツ)_/¯ I guess we gotta fix this then. |
This looks like it's pretty simple to fix, by changing the
|
Exposing more than one listener is blocked by two bugs:
We need to solve them first, before merging #9788 |
When there are multiple listeners configured for Addresses.API, serving metrics results in an errors: "<metric> was collected before with the same name and label values". This PR fixes this by maintaining a global map of metrics handlers, and only creating and reginstering them once. The same metrics handlers are provided to the mux for every listener. Fixes #9891 Fixes #9397 Unblocks #9637
Checklist
Description
By default, Kubo only listens on 127.0.0.1:5001 for api connections. With IPv6 usage growing, listening on [::1]:5001 as well should be default behavior.
The text was updated successfully, but these errors were encountered: