Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AutoTLS): opt-in WSS certs from p2p-forge at libp2p.direct #10521
feat(AutoTLS): opt-in WSS certs from p2p-forge at libp2p.direct #10521
Changes from 22 commits
ce6d09d
ecfc8d9
fe307da
bfc73d0
7c9842e
bef0a21
06708d8
af543af
946298b
d5994c1
7ae58bc
4889612
a038637
538c9bb
b306f56
9bd8ebb
21b5c88
7eeda1b
99b7757
e6e0b7a
ed7e201
e51d907
73c3fd3
e68493a
bcabbb4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is port
4082
used here?Can you use the same port as the
/ws
address:/ip4/0.0.0.0/tcp/4002/ws
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, we need libp2p/go-libp2p#2984 for that.
The idea is that TCP port sharing will land in go-libp2p before we enable AutoTLS by default.
For opt-in, using separate port is fine, just need to remember to remind people that they need to safelist additional port on their firewall.