Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parse_test.go #1193

Merged
merged 7 commits into from
May 4, 2015
Merged

Improve parse_test.go #1193

merged 7 commits into from
May 4, 2015

Conversation

chriscool
Copy link
Contributor

This improves go tests in parse_test.go so that it is easier to write more tests and tests are checking more things.

This will help if we want to fix issue #1141 (ipfs cat "multihash too short" error when using stdin).

@chriscool
parse_test: move helper functions
2a5b2f2 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
parse_test: fix and test sameWords()
3e4a069 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
parse_test: add tests for stdin enabled arg
d0752a7 
Let's document how stdin enabled arguments currently
work by adding some tests.

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
parse_test: improve tests with stdin enabled arg
58126c1 
Now also check that we get the right arguments from
the parsing.

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
parse_test: use fileToSimulateStdin()
c6dcfaa 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
parse_test: improve existing tests
47a88f8 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
parse_test: add testFail() to simplify tests
93f253e 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@jbenet jbenet added the status/in-progress In progress label May 3, 2015
@chriscool
Copy link
Contributor Author

One of the test failure is:

expecting success: 
    export IPFS_PATH="$IPTB_ROOT/2" &&
    NODE1_ID=`iptb get id 1` &&
    ipfs name publish /ipns/$NODE1_ID
Error: routing: not found
not ok 4 - add an entry on another node pointing to that one

The other one is:

No output has been received in the last ... minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

@jbenet
Copy link
Member

jbenet commented May 3, 2015

@whyrusleeping whatever the reason, iptb keeps failing :( -- should we disable it until we have fixed it? (the only other test that fails this (or more) frequently atm is the daemon teardown bug which i haven't disabled because... that would disable most of sharness)

@jbenet
Copy link
Member

jbenet commented May 3, 2015

@chriscool sorry, those errors are unrelated. :(

does anybody know why travis fails so often with

No output has been received in the last ... minutes, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated
?

@jbenet
Copy link
Member

jbenet commented May 3, 2015

this LGTM. anyone looking at the cli want to comment?

@whyrusleeping
Copy link
Member

@jbenet i'm pretty sure the iptb test failures are caused by the daemon teardown bug (or at least, they have the same cause)

@whyrusleeping
Copy link
Member

this LGTM too!

@chriscool chriscool mentioned this pull request May 4, 2015
Closed
jbenet added a commit that referenced this pull request May 4, 2015
@jbenet
Merge pull request #1193 from ipfs/improve_parse_test
9b12e02 
Improve parse_test.go
@jbenet jbenet merged commit 9b12e02 into master May 4, 2015
@jbenet jbenet removed the status/in-progress In progress label May 4, 2015
@jbenet jbenet deleted the improve_parse_test branch May 4, 2015 22:15
@jbenet jbenet mentioned this pull request May 9, 2015
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriscool @jbenet @whyrusleeping