make comments match the code in secure channel implementation #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks @dominictarr |
jbenet
added a commit
that referenced
this pull request
May 6, 2015
make comments match the code in secure channel implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing the secure channel I noticed some places where the comments said something different to what the code did. I have fixed the comments to match the code.
The first thing was in the cipher selection step, the comments said
cmp(hash(lr || rpub), hash(rr || lpub))but the code joined those the other way around. Also there was a spot later on where an earlier comment had been copypasted from before, and didn't make sense anymore.
I also noticed a few small improvements that could be made to the cipher selection process, but will post another issue.