Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t0040: add tests for ipfs cat with stdin #1250

Merged
merged 1 commit into from
May 20, 2015
Merged

t0040: add tests for ipfs cat with stdin #1250

merged 1 commit into from
May 20, 2015

Conversation

chriscool
Copy link
Contributor

These tests make sure that issue #1141 (ipfs cat "multihash too short" error when using stdin) is fixed and also adds more tests related to changes made in PR #1238.

License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org

@chriscool
t0040: add tests for ipfs cat with stdin
863f386 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@jbenet jbenet added the status/in-progress In progress label May 19, 2015
@chriscool
Copy link
Contributor Author

One go test failed with:

--- FAIL: TestGetBlockFromPeerAfterPeerAnnounces (1.00s)
    bitswap_test.go:82: context deadline exceeded
    bitswap_test.go:83: Expected to succeed
SIGQUIT: quit
PC=0x43f821

...

No output has been received in the last 10 minutes, ...

@jbenet
Copy link
Member

jbenet commented May 19, 2015

@chriscool this LGTM -- will merge as tests finish

@chriscool
Copy link
Contributor Author

Another go test failed with:

*** Test killed with quit: ran too long (10m0s).
FAIL    github.com/ipfs/go-ipfs/exchange/bitswap    600.026s

jbenet added a commit that referenced this pull request May 20, 2015
@jbenet
Merge pull request #1250 from ipfs/test-cat-with-stdin
7157574 
t0040: add tests for ipfs cat with stdin
@jbenet jbenet merged commit 7157574 into master May 20, 2015
@jbenet jbenet deleted the test-cat-with-stdin branch May 20, 2015 00:08
@jbenet jbenet removed the status/in-progress In progress label May 20, 2015
@wking wking mentioned this pull request Jun 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscool @jbenet