parse: fix handling of unwanted stdin #1255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2015 04:23
There can be non-terminal (i.e. non-interactive) sessions that are *not* a pipe, for example: ssh user@host ipfs version In this case, it looks like we should read from stdin. Parsing stdin is accomplished by deliberately triggering the parsing loop once. We didn't previously check whether there is an ArgDef to support that loop iteration.
|
Another way to reproduce this is |
|
Except the above suggested simplification, I think it is the right fix. |
|
with this patch applied echo ipfs config Addresses.Gateway /ip4/127.0.0.1/tcp/8080 | bash Still crashes, see #1260 (thx @chriscool) |
|
Closing in favor of #1263 |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be non-terminal (i.e. non-interactive) sessions
that are not a pipe, for example:
In this case, it looks like we should read from stdin.
Parsing stdin is accomplished by deliberately triggering
the parsing loop once.
We didn't previously check whether there is an ArgDef to support
that loop iteration.