Feat/snappy cmd #127
Merged
Feat/snappy cmd #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| return err | ||
| } | ||
| lk, err := lock.Lock(confdir + "/daemon.lock") |
There was a problem hiding this comment.
minor thing: "/daemon.lock" -> const daemonLock = "/daemon.lock"
jbenet
force-pushed
the
feat/snappy-cmd
branch
from
8a02252
to
1b0ec33
Compare
| lk, err := daemonLock(confdir) | ||
| if err == nil { | ||
| lk.Close() | ||
| return ErrDaemonNotRunning |
There was a problem hiding this comment.
i changed the order here, the lk.Close() was unreachable @whyrusleeping
|
I rebased this on top of new master. daemon_test is not there yet. Aside from an interface change, the test fails (looks like sync issues on close-- DaemonListener's |
|
Fixed the test now. This still needs to be rebased on top of new master (conflicts will happen). |
**For now**, we don't need to load/parse the private key (which causes a signficant delay in commands) when doing things entirely offline. This may change, and in that case the private key should be loaded on demand.
Erroring out in core setup should cancel the context to ensure subsystems are shut down. This has to happen all over the place we use contexts. @perfmode @whyrusleeping
jbenet
force-pushed
the
feat/snappy-cmd
branch
from
cbf2b28
to
7492a70
Compare
|
Okay, rebased on top of master resolving conflicts. :) shipping this. |
|
👍 |
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
misc test improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets get these changes reviewed and merged in, makes things a bit more... "snappy"