Better symmetric NAT avoidance. #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the same peer observed the same address twice, it would be double counted as different observations. This change adds a map to make sure we're counting each observer once. This is easily extended to require more than two observations, but i have not yet encountered NATs for whom this is relevant.
Different mutliaddrs is not enough. Nodes may share transports. NAT port mappings will likely only work on the base IP/TCP port pair. We go one step further, and require different root (IP) addrs. Just in case some NATs group by IP. In practice, this is what we want: use addresses only if hosts that are on different parts of the network have seen this address.
|
This should help a little bit with #1226 |
|
cc @whyrusleeping for CR. maybe i should've waited |
|
This LGTM. Hopefully it helps the netscan issues |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p2p/protocol/identify: dont double count observers
If the same peer observed the same address twice, it would be double
counted as different observations. This change adds a map to make sure
we're counting each observer once.
This is easily extended to require more than two observations, but i have
not yet encountered NATs for whom this is relevant.
p2p/net/identify: clump addr observers into groups
Different mutliaddrs is not enough. Nodes may share transports. NAT port
mappings will likely only work on the base IP/TCP port pair. We go one step
further, and require different root (IP) addrs. Just in case some NATs
group by IP. In practice, this is what we want: use addresses only if hosts
that are on different parts of the network have seen this address.