-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPFS Bootstrap Command #137
Conversation
|
||
Shows a list of bootstrapped addresses. use 'add' or 'remove' followed | ||
by a specified <address> to add/remove it from the list. | ||
`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
Long: `ipfs bootstrap - show, or manipulate bootstrap node addresses
SECURITY WARNING:
The bootstrap command manipulates the "bootstrap list", which contains
the addresses of bootstrap nodes. These are the *trusted peers* from
which to learn about other peers in the network. Only edit this list
if you understand the risks of adding or removing nodes from this list.
Running 'ipfs bootstrap' with no arguments will run 'ipfs bootstrap list'.
Commands:
list Show the boostrap list.
add <address> Add a node's address to the bootstrap list.
remove <address> Remove an address from the bootstrap list.
`,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was fixed
Hey @llSourcell thanks for the PR! Very much appreciated. But please familiarize yourself more with Go and with the codebase. This duplicates a lot of code and ignores existing facilities. Since I take it you're new to Go, in the future, maybe a good idea would be to propose the changes you'll be making by describing the design first, so that I or others can point you in the right direction before wasting your time duplicating code. |
np, thanks for the CR. This was a personal lesson in distributed team communication. I'll vocalize what I'm doing more. |
alright fixed everything |
@llSourcell these changes do not address the comments-- for example, still not using subcommands. Please look back through all of them. Github hides outdated diffs, so make sure to open those |
k thx. re: multiaddr and subcommands- i'm on it. |
ok everything addressed except multiaddr because multiaddr doesn't yet contain peerIDs so we have to parse them manually for now. |
Great! Thanks for addressing those, @llSourcell |
Can't automatically merge, so will merge manually. |
I'm going to have to squash the history. It's not |
rebased, squashed history because of fmting, improved and resubmitted at #144 (cant push to this branch) |
update peer-id public key extraction (and more!)
Resolution to issue #117
All of the features work as described in the issue referenced.
The peers are added to the config file. You can add new peers, delete those new peers, and list all peers.