Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS Bootstrap Command #137

Closed
wants to merge 20 commits into from
Closed

IPFS Bootstrap Command #137

wants to merge 20 commits into from

Conversation

llSourcell
Copy link
Contributor

Resolution to issue #117

All of the features work as described in the issue referenced.

The peers are added to the config file. You can add new peers, delete those new peers, and list all peers.

@llSourcell llSourcell changed the title IPFS Bootstrap Plumbing Command IPFS Bootstrap Command Oct 2, 2014

Shows a list of bootstrapped addresses. use 'add' or 'remove' followed
by a specified <address> to add/remove it from the list.
`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

    Long: `ipfs bootstrap - show, or manipulate bootstrap node addresses

SECURITY WARNING:

The bootstrap command manipulates the "bootstrap list", which contains 
the addresses of bootstrap nodes. These are the *trusted peers* from 
which to learn about other peers in the network. Only edit this list 
if you understand the risks of adding or removing nodes from this list.

Running 'ipfs bootstrap' with no arguments will run 'ipfs bootstrap list'.

Commands:

  list               Show the boostrap list.
  add <address>      Add a node's address to the bootstrap list.
  remove <address>   Remove an address from the bootstrap list.

`,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was fixed

@jbenet
Copy link
Member

jbenet commented Oct 2, 2014

Hey @llSourcell thanks for the PR! Very much appreciated.

But please familiarize yourself more with Go and with the codebase. This duplicates a lot of code and ignores existing facilities. Since I take it you're new to Go, in the future, maybe a good idea would be to propose the changes you'll be making by describing the design first, so that I or others can point you in the right direction before wasting your time duplicating code.

@llSourcell
Copy link
Contributor Author

np, thanks for the CR. This was a personal lesson in distributed team communication. I'll vocalize what I'm doing more.

@llSourcell
Copy link
Contributor Author

alright fixed everything

@jbenet
Copy link
Member

jbenet commented Oct 3, 2014

@llSourcell these changes do not address the comments-- for example, still not using subcommands. Please look back through all of them. Github hides outdated diffs, so make sure to open those

@llSourcell
Copy link
Contributor Author

k thx. re: multiaddr and subcommands- i'm on it.

@llSourcell
Copy link
Contributor Author

ok everything addressed except multiaddr because multiaddr doesn't yet contain peerIDs so we have to parse them manually for now.

@jbenet
Copy link
Member

jbenet commented Oct 5, 2014

Great! Thanks for addressing those, @llSourcell

@jbenet
Copy link
Member

jbenet commented Oct 6, 2014

Can't automatically merge, so will merge manually.

@jbenet
Copy link
Member

jbenet commented Oct 6, 2014

I'm going to have to squash the history. It's not go-fmt ed at all, and causing conflicts with the rebase. In the future, you want to make to (or make your editor) run go fmt (and golint while at it) before committing. Most editors have nice plugins that do it all for you on save.

@jbenet jbenet mentioned this pull request Oct 6, 2014
@jbenet
Copy link
Member

jbenet commented Oct 6, 2014

rebased, squashed history because of fmting, improved and resubmitted at #144 (cant push to this branch)

@jbenet jbenet closed this Oct 6, 2014
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
update peer-id public key extraction (and more!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants