Pinning

[jbenet]

No description provided.

[jbenet]

👍 yes. murmur is pretty good. Also, cityhash. Will add links.

[jbenet]

Links on hashing for bloom filters:

• https://code.google.com/p/go/issues/detail?id=2630
• https://groups.google.com/forum/#!msg/golang-nuts/YMc8eoaRJcE/ONTuMnnVpKIJ
• https://github.com/dataence/cityhash
• https://131002.net/siphash/ (secure + fast)

[whyrusleeping]

Cool, I just threw three random ones in there to get things working

[jbenet]

yeah, i just threw a bunch of links for future ref, not now :)

[jbenet]

ds.Key is designed with namespacing/prefixing in mind:

type datastoreBlockSet struct {
  ...
  prefix ds.Key
}

func NewDBWrapperSet(d ds.Datastore, prefix string, bset BlockSet) BlockSet {
  return &datastoreBlockSet{
    dstore: d,
    bset:   bset,
    prefix: ds.NewKey(prefix),
  }
}

func (d *datastoreBlockSet) prefixKey(k util.Key) ds.Key {
  return d.prefix.Child(string(k))
}

[jbenet]

@whyrusleeping done reviewing this. a few notes (mainly cli, and threadsafe), but otherwise LGTM!

[jbenet]

@whyrusleeping LGTM! Merge in after rebasing.

One last q: right now, does ipfs pin add <hash> flush the pin to disk? (I'm failing to see where if so)

[whyrusleeping]

hmm... it probably should do that... un moment

[jbenet]

woooo! pinning!

(this gif is apt in many ways)