-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows builds fix #1875
windows builds fix #1875
Conversation
d483abd
to
56a5d35
Compare
This also now makes windows builds part of the CI process. |
I don't see where wmi and ole are used? Or does the import in rest LGTM |
@cryptix theyre used in the library we're importing to gather system diagnostics information |
Aah.. I see! maybe want to group them with comment together with |
probably a good idea. |
You may ignore this comment because its only purpose is to make this issue to appear in my https://github.com/notifications/participating I want to be automatically notified when a working IPFS build for Windows appears. |
@Mithgol there is a button on the side of the issue you can click to subscribe to issue notifications. |
@whyrusleeping I know, but that button adds this issue to the long list https://github.com/notifications/ but not to the shorter list https://github.com/notifications/participating (unless I have misunderstood something). |
@Mithgol please dont do that, it just adds noise to the comment chain, the comment chain for pull requests is intended just for code review, if there is an open issue about windows builds failing you can comment there to subscribe to notifications, or if there isnt one, you can open an issue, and mention this PR in the issue. Otherwise, just use the subscribe button here. |
@whyrusleeping maybe rebase, since it's big? |
a0c74dc
to
a838b6b
Compare
rebased. |
@jbenet RFM? |
@whyrusleeping this still needs rebasing |
# since we have CI for osx and linux but not windows, this should help | ||
windows_build_check: | ||
GOOS=windows GOARCH=amd64 go build -tags=nofuse ./cmd/ipfs | ||
rm ipfs.exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to place it somewhere the user may not have one they use. lime use the output flag and put it in .ipfs.exe
or something
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
a838b6b
to
e6121db
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
e6121db
to
89787b9
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
89787b9
to
8d63402
Compare
@Mithgol want to test master now? |
@jbenet currently it does not seem like there is a Windows build of IPFS at https://gobuilder.me/github.com/ipfs/go-ipfs/cmd/ipfs |
Still choked on <go1.5 |
IPFS version 0.3.9 on Windows seems fine (i.e. I haven't encountered any obvious errors yet). |
@Mithgol great to hear! sorry it took so long |
this fixes builds on windows, and also fixes a couple of the test failures (not all of them, just some of the easy ones i saw)