make swarm connect return an error when it fails

[whyrusleeping]

@diasdavid made me look at this code a little more and i realized that if it fails, you wont know about it through the api.

This should fix that.

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

[daviddias]

sweet :D thanks @whyrusleeping !

[jbenet]

👍

[jbenet]

@whyrusleeping i merged that too aggressively, i think we want to add a test case here to ensure that a failure does indeed fail with an API error.

[jbenet]

@diasdavid @whyrusleeping how do you guys feel about maybe leading feature development with test cases, i.e. this report could've started with a test case.

[whyrusleeping]

how do you guys feel about maybe leading feature development with test cases, i.e. this report could've started with a test case.

Not opposed to that.

[daviddias]

I like that. In this case, the test was on the node-ipfs-api, should that be considered as a valid test case?

[jbenet]

@diasdavid not easy to run test case, and too broad. I think it could be a small sharness test here. 

—
Sent from Mailbox

On Tue, Oct 27, 2015 at 8:20 PM, David Dias notifications@github.com
wrote:

I like that. In this case, the test was on the node-ipfs-api, should that be considered as a valid test case?

Reply to this email directly or view it on GitHub:
#1900 (comment)

[jbenet]

Should be something that fails this repo CI I think

—
Sent from Mailbox

On Tue, Oct 27, 2015 at 8:20 PM, David Dias notifications@github.com
wrote:

I like that. In this case, the test was on the node-ipfs-api, should that be considered as a valid test case?

Reply to this email directly or view it on GitHub:
#1900 (comment)