fix close notify

[whyrusleeping]

Our multipart file code cannot handle sending zero files. So if the number of input files is nil, don't do any multipart stuff.

Also did some other cleanup along the way to make debugging easier.

[whyrusleeping]

hrm... the test i'm writing will be a LOT easier with #2003. I'm trying to use netcat to capture the http request, but the version check goes first and i capture that instead...

[rht]

This surely fixes the closenotify problem, but not entirely obvious why.
The first roundtrip circle is somehow completed.

[rht]

#2003 is currently on dev0.4.0

[whyrusleeping]

@rht the close notify issue appeared to be because the client was sending a malformed http request body. That caused the server side to mess up for some reason and not figure out how the close notify should happen for some reason.

[jbenet]

is this no longer true, then?

[whyrusleeping]

it was actually never true, as far as i can tell, at least since april 2014.

[jbenet]

this LGTM in general.

@whyrusleeping maybe write a proxy that checks the contents are fine, but still fwds the request to something else? not sure.

[whyrusleeping]

maybe write a proxy that checks the contents are fine, but still fwds the request to something else? not sure.

@jbenet i was going to do that with netcat, but it will be difficult before #2003

I think I might just merge the test i have in after that one lands

[jbenet]

@jbenet i was going to do that with netcat, but it will be difficult before #2003

that's why "proxy that checks the contents are fine, but still fwds the request to something else" -- a proxy would not have a problem with the version check, it would go through it fine.

[whyrusleeping]

I mean, if we want to have another bit of go code to do that we can. But at that point, we might as well just test it exclusively in go

[jbenet]

ok that's fine, as long as it is a real test (testing with the full api service running).

fwiw, having a tool that can proxy + verify certain things pass through will be useful anyway. imagine something like:

cat testfile
> grep ^Hello Server$
< grep ^Hello Client$
> grep ^Here are [0-9]+ things$
+> grep $Thing [0-9]+$
> grep ^Done$
< grep ^Ok got [0-9]+ things

cat testfile | testproxy --port 5679 1.2.3.4:5678

this may be overkill for now though :)

[rht]

For the test, #2003 -> #2037.

[cryptix]

LGTM

[whyrusleeping]

this has been long in coming and is actively causing issues, merging.