fix t.Fatal in a goroutine #2062
Conversation
chriscool
force-pushed
the
fix-t-fatal-goroutine
branch
3 times, most recently
from
59653ef to
1bc2ebd
Compare
chriscool
changed the title
|
Test failures are in Sharness tests and are not related. |
| @@ -142,6 +142,7 @@ func sizeOfIthFile(i int64) int64 { | |||
| } | |||
|
|
|||
| func runFileAddingWorker(n *core.IpfsNode) error { | |||
| errs := make(chan error, math.MaxInt32) | |||
There was a problem hiding this comment.
what... what is going on in this test? MaxInt32 ?
your changes look good to me, but we should probably reevaluate what this test is doing...
There was a problem hiding this comment.
i believe this thing used to just sit, adding a new file every second. it could just as well loop forever.
|
Looks good! this may help flush out some issues, especially the ones in bitswap. Those might be the cause of our occasional bitswap test hang. Only thing I would do is to not buffer the error channels, the pattern youre using should work fine with no buffering. |
|
@whyrusleeping ok thanks for your review. I will wait a bit before for @jbenet or someone else's opinion before removing the error channel buffers though. |
| @@ -168,19 +168,31 @@ func PerformDistributionTest(t *testing.T, numInstances, numBlocks int) { | |||
| t.Log("Distribute!") | |||
|
|
|||
| wg := sync.WaitGroup{} | |||
| errs := make(chan error, 10) | |||
There was a problem hiding this comment.
here this could be make(chan error, len(instances))
yeah that sounds good to me, no buffering is fine |
|
this LGTM, other than no buffers |
License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
chriscool
force-pushed
the
fix-t-fatal-goroutine
branch
from
1bc2ebd to
57c4188
Compare
|
Ok, I removed all the buffering. |
This should fix at least part of issue #2043.
License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org