Docker image volume fix and Sharness tests

[chriscool]

This PR contains @ChristianKniep's fix from PR #1806 (change Dockerfile order to create VOLUME under user ipfs) and add a Sharness test script (t0300) with some docker tests.
@ChristianKniep's fix is fixing issue #1804 (Boot2Docker: VOLUME prevents chown to have effect).

[chriscool]

Circle CI is failing with:

expecting success: 
    docker build --rm "$APP_ROOT_DIR" >actual

Post http:///var/run/docker.sock/v1.20/build?cgroupparent=&cpuperiod=0&cpuquota=0&cpusetcpus=&cpusetmems=&cpushares=0&dockerfile=Dockerfile&memory=0&memswap=0&rm=1&t=&ulimits=null: dial unix /var/run/docker.sock: no such file or directory.
* Are you trying to connect to a TLS-enabled daemon without TLS?
* Is your docker daemon up and running?
not ok 5 - docker image build succeeds

I am not sure it supports docker or maybe some options are needed to make it run docker.

[chriscool]

About CircleCI I found an option in the doc for docker support, so I added a commit to set it.

[chriscool]

Travis-CI supports Docker on Linux only for now.
Let's use a prereq to not run Docker tests on OSX.

[chriscool]

travis-ci/push has this failure in go tests:

14:00:29.390 ERROR     swarm2: swarm listener accept error: peerstream listener failed: accept tcp 127.0.0.1:57236: use of closed network connection swarm_listen.go:129

14:00:29.390 ERROR     swarm2: swarm listener accept error: peerstream listener failed: accept tcp 127.0.0.1:48892: use of closed network connection swarm_listen.go:129

14:00:29.391 ERROR     swarm2: swarm listener accept error: peerstream listener failed: accept tcp 127.0.0.1:46832: use of closed network connection swarm_listen.go:129

14:00:29.395 ERROR     swarm2: swarm listener accept error: peerstream listener failed: accept tcp 127.0.0.1:32841: use of closed network connection swarm_listen.go:129

--- FAIL: TestDialWait (0.02s)

    dial_test.go:103: failed to specify addrs: [/ip6/::/tcp/42276]

14:00:29.418 ERROR     swarm2: swarm listener accept error: peerstream listener failed: accept tcp 127.0.0.1:38928: use of closed network connection swarm_listen.go:129

--- FAIL: TestDialBackoffClears (0.05s)

    dial_test.go:103: failed to specify addrs: [/ip6/::/tcp/35358]

14:00:29.483 ERROR     swarm2: swarm listener accept error: peerstream listener failed: accept tcp 127.0.0.1:54142: use of closed network connection swarm_listen.go:129

14:00:29.490 ERROR     swarm2: swarm listener accept error: peerstream listener failed: accept tcp 127.0.0.1:47706: use of closed network connection swarm_listen.go:129 

[chriscool]

I rebased to remove debug output.

[chriscool]

We get "Unsupported: Exec is not supported by the lxc driver" with CircleCi.

It looks like "docker exec" doesn't work on CircleCi:

https://circleci.com/docs/docker#docker-exec

[chriscool]

I think I will have to do something like this:

exec_docker() {
    if test "$CIRCLECI" = 1
    then
        sudo lxc-attach -n "$(docker inspect --format '{{.Id}}' $1)" -- bash -c "$2"
    else
        docker exec -i "$1" /bin/bash -c "2"
    fi
}

[chriscool]

There is this error on travis-ci/push:

expecting success: 

        ipfs add -r --hidden mountdir/planets >actual



ok 12 - 'ipfs add -r --hidden' succeeds

expecting success: 

        cat >expected <<-\EOF &&

            added QmcAREBcjgnUpKfyFmUGnfajA1NQS5ydqRp7WfqZ6JF8Dx planets/.asteroids/ceres.txt

            added QmZ5eaLybJ5GUZBNwy24AA9EEDTDpA4B8qXnuN3cGxu2uF planets/.asteroids/pallas.txt

            added Qmf6rbs5GF85anDuoxpSAdtuZPM9D2Yt3HngzjUVSQ7kDV planets/.asteroids

            added QmaowqjedBkUrMUXgzt9c2ZnAJncM9jpJtkFfgdFstGr5a planets/.charon.txt

            added QmU4zFD5eJtRBsWC63AvpozM9Atiadg9kPVTuTrnCYJiNF planets/.pluto.txt

            added QmZy3khu7qf696i5HtkgL2NotsCZ8wzvNZJ1eUdA5n8KaV planets/mars.txt

            added QmQnv4m3Q5512zgVtpbJ9z85osQrzZzGRn934AGh6iVEXz planets/venus.txt

            added QmetajtFdmzhWYodAsZoVZSiqpeJDAiaw2NwbM3xcWcpDj planets

        EOF

        test_cmp expected actual



> diff -u expected actual

--- expected    2015-12-13 14:14:43.270334999 +0000

+++ actual  2015-12-13 14:14:43.258334999 +0000

@@ -1,8 +1,8 @@

-added QmcAREBcjgnUpKfyFmUGnfajA1NQS5ydqRp7WfqZ6JF8Dx planets/.asteroids/ceres.txt

-added QmZ5eaLybJ5GUZBNwy24AA9EEDTDpA4B8qXnuN3cGxu2uF planets/.asteroids/pallas.txt

-added Qmf6rbs5GF85anDuoxpSAdtuZPM9D2Yt3HngzjUVSQ7kDV planets/.asteroids

+added QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH planets/.asteroids/ceres.txt

+added QmTF2HDVTJMXWGUkrtAFfQpYxom5A8Tj7S38SzPfGVCD5P planets/.asteroids/pallas.txt

+added Qmed5hbZhHpbTEmmTGiVStW6oMmZqDorNkMwV4aWWbbWPf planets/.asteroids

 added QmaowqjedBkUrMUXgzt9c2ZnAJncM9jpJtkFfgdFstGr5a planets/.charon.txt

 added QmU4zFD5eJtRBsWC63AvpozM9Atiadg9kPVTuTrnCYJiNF planets/.pluto.txt

 added QmZy3khu7qf696i5HtkgL2NotsCZ8wzvNZJ1eUdA5n8KaV planets/mars.txt

 added QmQnv4m3Q5512zgVtpbJ9z85osQrzZzGRn934AGh6iVEXz planets/venus.txt

-added QmetajtFdmzhWYodAsZoVZSiqpeJDAiaw2NwbM3xcWcpDj planets

+added Qma69eGiYgSFiuzUvM5yPDsXyvmGVgaryQE84qYnehCk2r planets

not ok 13 - 'ipfs add -r --hidden' did include . files

[chriscool]

On travis-ci/pr there is this error:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated

[jbenet]

Travis-CI supports Docker on Linux only for now.
Let's use a prereq to not run Docker tests on OSX.

ok

I think I will have to do something like this:

exec_docker()

wow, bummer. maybe put that in a shell scrpt and call it docker-exec, we can call that everywhere we want to do docker exec.

There is this error on travis-ci/push:

the hashes seem different. content somehow different??

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

ugh yeah that sometimes happens. there's some test that hangs travis-- we should look into them. unrelated i think

[jbenet]

the closed network connection stuff is odd. probably some issue with the docker networking

[chriscool]

Yeah, with the docker_exec() that has a special case for CircleCI it works on CircleCI!
The other build failures are the usual ones on Travis OSX and in the go tests.

[jbenet]

@chriscool i think the go test failure here is not a usual one-- i do not think i have seen it on travis without docker.

[chriscool]

The got test errors are:

22:15:58.314 ERROR     swarm2: swarm listener accept error: peerstream listener failed: accept tcp 127.0.0.1:48529: use of closed network connection swarm_listen.go:129

22:15:58.319 ERROR     swarm2: swarm listener accept error: peerstream listener failed: accept tcp 127.0.0.1:44342: use of closed network connection swarm_listen.go:129

--- FAIL: TestDialWait (0.02s)

    dial_test.go:103: failed to specify addrs: [/ip6/::/tcp/32781]

--- FAIL: TestDialBackoffClears (0.03s)

    dial_test.go:103: failed to specify addrs: [/ip6/::/tcp/41355]

Yeah, they are perhaps related to the Travis CI environment with docker.

@whyrusleeping do you know what in the Travis CI environment with docker could cause those failures?

[whyrusleeping]

@chriscool i've got the ipv6 stuff fixed now, but it appears that travis and t0042 don't get along well...

[chriscool]

@whyrusleeping I think the Travis tests passed except the usual No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself errors.

[chriscool]

And one of those failures is on Linux not OSX!
See: https://travis-ci.org/ipfs/go-ipfs/jobs/101416974

[chriscool]

It's the one from continuous-integration/travis-ci/pr.

[whyrusleeping]

LGTM

[chriscool]

Rebased on current master. Let's have a look at the tests.