fix bootstrapping bug and add real test for bootstrapping #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
| // of the codebase currently uses addresses without the peerid part. | ||
| m := bp.Multiaddr() | ||
| s := ma.Split(m) | ||
| m = ma.Join(s[:len(s)-1]...) |
There was a problem hiding this comment.
this whole bit could have just been bp.Transport()
whyrusleeping
force-pushed
the
fix/bootstrapping
branch
3 times, most recently
from
42781ab
to
39d0b33
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
added a commit
that referenced
this pull request
Jan 17, 2016
fix bootstrapping bug and add real test for bootstrapping
|
Thank you. I retested my setup and bootstrap works fine now 👍 |
|
@lidel yay!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com