fix(everything) log.Debug -> log.Debugf #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +70,7 @@ func (s *BlockService) GetBlock(ctx context.Context, k u.Key) (*blocks.Block, er | |||
| log.Debugf("BlockService GetBlock: '%s'", k) | |||
| datai, err := s.Datastore.Get(k.DsKey()) | |||
| if err == nil { | |||
| log.Debug("Blockservice: Got data in datastore.") | |||
| log.Debugf("Blockservice: Got data in datastore.") | |||
There was a problem hiding this comment.
this shouldn't be log.Debugf. it should just be log.Debug ...
There was a problem hiding this comment.
Yeah. It's my understanding that Debugf("a string") is functionally equivalent to Debug("string") but not the other wat around.
Ideally, Debug isn't even in the interface so we guard against programmer error.
There was a problem hiding this comment.
it's not equivalent. This works:
log.Debug("a", "b", 1123) // a b 1123
Turning that into a log.Debugf will break it.
There was a problem hiding this comment.
Ah. Okay. I'll reset --soft and run through this with a fine toothed comb and ping.
|
revised @jbenet |
|
LGTM |
jbenet
added a commit
that referenced
this pull request
Oct 31, 2014
fix(everything) log.Debug -> log.Debugf
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
fix(everything) log.Debug -> log.Debugf
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
Fix races with DialQueue variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whyrusleeping @jbenet