feat(docker) build a daemon #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default Docker build creates a daemon. TODO allow bootstrap node to be overridden at runtime (perhaps with an environment variable), so we can use custom topologies in test environments. NB: We still want the default behavior to connect to Mars. TODO create a docker image that mounts and uses shared volume to make that mount accessible on the host.
|
👍 |
|
|
+1. or --bootstrap Maybe we should have an |
|
+1 |
|
-1 on multiple flags like that. that complicates commands package and is ambiguous depending on interpretation. is it an array? is it an overridden string? I filed multiformats/multiaddr#5 to think of a good way to represent multiaddrs in a set. |
|
Fair. One bootstrap node for now is fine by me. |
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
gx publish 4.4.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbenet Quick change.
The default Docker build now creates a daemon without mounting.
TODO allow bootstrap node to be overridden at runtime (perhaps with an
environment variable), so we can use custom topologies in test
environments. NB: We still want the default behavior to connect to Mars.
TODO create a docker image that mounts (and uses shared volume to make
that mount accessible on the host).