Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for v0.4.2 #2714

Merged
merged 2 commits into from
May 17, 2016
Merged

Add changelog for v0.4.2 #2714

merged 2 commits into from
May 17, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2016

Everybody PTAL -- did I overlook anything?

* Set a deadline for dialing attempts. This prevents a node from accumulating
failed connections. (@whyrusleeping)
* Avoid unneccessary string/byte conversions in go-multihash. (@whyrusleeping)
* Fix a deadlock around the yamux stream muxer. (@whyrusleeping)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be good to start linking to the various issues, shrug

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entries here often don't match one-to-one with a PR -- but I agree that for the interesting changes it'd be pretty useful.

Next time? :) Or I can give it another go tomorrow.

* Documentation
* Add a debug-guidelines document. (@richardlitt)
* Update the contribute document. (@richardlitt)
* Fix documentation of all `ipfs` commands. (@richardlitt)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be more detailed than this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: Improved default documentation and logic for mostipfscommand options

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool, suggestions? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, what is this meant to be for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be split into "Fix default values of many ipfs commands" and "Improve commands documentation"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we cover that below. What were you referring to in this comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

@whyrusleeping
Copy link
Member

LGTM. I think its time to hop on the release train!

Lars Gierth and others added 2 commits May 17, 2016 22:31
License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@ghost
Copy link
Author

ghost commented May 17, 2016

This is good to go

@ghost ghost added the RFM label May 17, 2016
@whyrusleeping whyrusleeping merged commit 0f33a56 into master May 17, 2016
@whyrusleeping whyrusleeping deleted the changelog-0.4.2 branch May 17, 2016 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants