Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement some simple dht request read timeouts #2863

Merged
merged 2 commits into from
Jun 20, 2016
Merged

Conversation

whyrusleeping
Copy link
Member

Very occasionally the remote side will stop sending on a stream, not close it, and not close the underlying tcp connection. This causes annoying hangs

License: MIT
Signed-off-by: Jeromy why@ipfs.io

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@Kubuxu
Copy link
Member

Kubuxu commented Jun 17, 2016

LGTM, as we talked on IRC, it isn't the best solution possible but complexity of others makes good.

@Kubuxu Kubuxu added the RFM label Jun 17, 2016
@whyrusleeping
Copy link
Member Author

running this on my computer, i got one timeout logged. And unfortunately (or fortunately?) there arent any correlated yamux errors

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping whyrusleeping merged commit 720fa80 into master Jun 20, 2016
@whyrusleeping whyrusleeping deleted the fix/dht-timeouts branch June 20, 2016 16:50
@jbenet
Copy link
Member

jbenet commented Aug 27, 2016

We should come up with very strict guidelines on what it's ok to add this sort of timeout, and how to make it configurable. this is the sort of thing that doesn't scale with the physical size of the network (eg across planets).

@jbenet jbenet mentioned this pull request Aug 28, 2016
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants