fix handling of dht records and local fixups #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
fix/dht-key-handling
branch
from
1825fd2 to
3e54fb4
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
| log.Error("Error correcting local dht entry:", err) | ||
| } | ||
| return | ||
| } |
There was a problem hiding this comment.
I guess this is what the self-dials where from?
There was a problem hiding this comment.
Yeap, that was indeed the source
whyrusleeping
force-pushed
the
fix/dht-key-handling
branch
from
f67f39a to
735964d
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
fix/dht-key-handling
branch
from
735964d to
b56d481
Compare
|
LGTM! |
|
circleCI failure appears to be a caching issue |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple bugs that made ipns not work well in cases where the peer ID had a '/' in it.
It also fixes a bug where we would never succeed in updating the locally stored entry
License: MIT
Signed-off-by: Jeromy why@ipfs.io