Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use $(MAKE) instead of 'make' in Makefiles (follow-up to f3dc11c) #3265

Merged
merged 1 commit into from
Sep 28, 2016

Conversation

vasild
Copy link
Contributor

@vasild vasild commented Sep 26, 2016

License: MIT
Signed-off-by: Vasil Dimov vd@FreeBSD.org

License: MIT
Signed-off-by: Vasil Dimov <vd@FreeBSD.org>
@ghost
Copy link

ghost commented Sep 26, 2016

Does $(MAKE) resolve to whatever make binary is currently running, while just make will use $PATH to resolve, and might end up with a different binary? In that case, LGTM.

@ghost ghost added topic/portability Topic portability topic/build Topic build labels Sep 26, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Sep 26, 2016

Yes it is the case, also $(MAKE) works on BSDs where you have to build go-ipfs with gmake as we use GNU extensions in some places.

@vasild
Copy link
Contributor Author

vasild commented Sep 27, 2016

Right, the problem this patch addresses is that the FreeBSD port does set MAKE=gmake in the environment and also runs it as "gmake ...whatever..." but a hardcoded make command in the Makefile ends up picking up /usr/bin/make from PATH. There are also lots of other places in this Makefile which use $(MAKE), I guess this hardcoded "make" was forgotten in f3dc11c which did s/make/$(MAKE)/.

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whyrusleeping whyrusleeping merged commit abe44b8 into ipfs:master Sep 28, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/build Topic build topic/portability Topic portability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants