Add PosInfo() method to blocks and merkeldag nodes. #3309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevina
added
need/review
The PosInfo() method contains information on the original file the block/node was created from. It contains enough information to recreate a leaf node's data from the file such as the filename and the offset. The PosInfo is set when building the DAG in the Balanced builder. License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org>
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org>
kevina
force-pushed
the
kevina/posinfo
branch
from
d161d02
to
39e494b
Compare
|
Closing in favor of #3314. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whyrusleeping, we discussed most of these changes earlier in #2634 (or the previous one #2600).
The changes are fairly small but I would like to get these in ASAP as it looks like the next set of CID chances (#3301 and #3307) will be touching related areas of code.
These changes are fundamental to the filestore and are thus tested extensively in #2634. I also created a simple test to make sure PosInfo() is being used.