Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds-help: add helper functions to convert from Cid to DsKey and the reverse #3310

Merged
merged 1 commit into from
Oct 18, 2016
Merged

ds-help: add helper functions to convert from Cid to DsKey and the reverse #3310

merged 1 commit into from
Oct 18, 2016

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Oct 16, 2016

In the filestore (#2634) i needed to convert from Cid to DsKey and the reverse in several places so I created two helper functions to that effect.

@kevina kevina added the status/in-progress In progress label Oct 16, 2016
@kevina kevina mentioned this pull request Oct 16, 2016
Closed
6 tasks
@kevina kevina added need/review Needs a review status/ready Ready to be worked and removed status/in-progress In progress labels Oct 16, 2016
@whyrusleeping
Copy link
Member

Maybe these should be in the dshelper package?

@kevina
Copy link
Contributor Author

kevina commented Oct 17, 2016

I take it you mean thirdparty/ds-help. I thought about that, but it will add a dependency to that small package and also these methods are used in the same places the blockstore is used so I thought the blockstore package was a better place to avoid having yet another import. I can move it though, just give the word.

@whyrusleeping
Copy link
Member

@kevina the thing is that your helper methods would be useful in nearly every place that that package is used.

@kevina
Copy link
Contributor Author

kevina commented Oct 17, 2016

No problem, I'll move it.

@kevina
ds-help: add helper func to convert from Cid to DsKey and the reverse
c4fbe34 
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@kevina kevina changed the title blockstore: add helper functions to convert from Cid to DsKey and the reverse ds-help: add helper functions to convert from Cid to DsKey and the reverse Oct 17, 2016
@kevina
Copy link
Contributor Author

kevina commented Oct 17, 2016

@whyrusleeping, moved

whyrusleeping
whyrusleeping approved these changes Oct 18, 2016
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevina kevina added the RFM label Oct 18, 2016
@kevina
Copy link
Contributor Author

kevina commented Oct 18, 2016

@whyrusleeping tests passed. Marking a RFM.

@kevina kevina removed the need/review Needs a review label Oct 18, 2016
@whyrusleeping whyrusleeping merged commit 716aa86 into master Oct 18, 2016
@whyrusleeping whyrusleeping deleted the kevina/cid2dskey branch October 18, 2016 17:24
@whyrusleeping whyrusleeping removed the status/ready Ready to be worked label Oct 18, 2016
@kevina kevina added this to the Filestore implementation milestone Oct 19, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
RFM
Projects
None yet
Milestone
Filestore implementation
Development

Successfully merging this pull request may close these issues.
2 participants
@kevina @whyrusleeping