Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockstore: fix TODO and avoid calling ds.NewKey #3379

Merged
merged 1 commit into from
Nov 14, 2016
Merged

blockstore: fix TODO and avoid calling ds.NewKey #3379

merged 1 commit into from
Nov 14, 2016

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Nov 14, 2016

Doesn't help that much though, see #3376.

@kevina
blockstore: fix TODO and avoid calling ds.NewKey
d48d904 
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@kevina kevina added status/in-progress In progress topic/perf Performance labels Nov 14, 2016
@kevina kevina mentioned this pull request Nov 14, 2016
Closed
@whyrusleeping
Copy link
Member

👍 LGTM, nice

@whyrusleeping whyrusleeping merged commit 580584a into master Nov 14, 2016
@whyrusleeping whyrusleeping deleted the kevina/blockstore-nonewkey branch November 14, 2016 17:23
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Nov 14, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
topic/perf Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevina @whyrusleeping