Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm/peers: print 'n/a' instead of zero latency #3491

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

whyrusleeping
Copy link
Member

closes #3125

License: MIT
Signed-off-by: Jeromy why@ipfs.io

@whyrusleeping whyrusleeping added the status/in-progress In progress label Dec 9, 2016
@whyrusleeping whyrusleeping requested review from a user and Kubuxu December 9, 2016 05:55
@whyrusleeping whyrusleeping added this to the ipfs 0.4.5 milestone Dec 9, 2016
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@Kubuxu
Copy link
Member

Kubuxu commented Dec 9, 2016

Cleaner fix would be to have LatencyEWMA return err or -1 when latency is not found.

But as it is a float and it is in miliseconds real latency of 0 is rather impossible. LGTM

@whyrusleeping whyrusleeping merged commit 477787c into master Dec 9, 2016
@whyrusleeping whyrusleeping deleted the fix/swarm-peers-0-lat branch December 9, 2016 20:06
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Dec 9, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipfs swarm peers -v may output a 0 latency
2 participants