Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(daemon) ipfs daemon --initialized #355

Merged
merged 27 commits into from
Nov 18, 2014
Merged

feat(daemon) ipfs daemon --initialized #355

merged 27 commits into from
Nov 18, 2014

Commits on Nov 17, 2014

  1. deps(go-datastore) update 

    This commit updates go-datastore in order to access new LevelDb Close()
method

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    Brian Tiger Chow committed Nov 17, 2014
    Configuration menu
    Copy the full SHA
    5fa31f8 View commit details
    Browse the repository at this point in the history

  2. refactor(errors) debugerror -> errors 

    License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    Brian Tiger Chow committed Nov 17, 2014
    Configuration menu
    Copy the full SHA
    cf8fb87 View commit details
    Browse the repository at this point in the history

  3. feat(util) FileExists 

    License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    Brian Tiger Chow committed Nov 17, 2014
    Configuration menu
    Copy the full SHA
    11fd2aa View commit details
    Browse the repository at this point in the history

  4. fix(daemon) if lock file does not exist, then the lock is not acquired 

    @mappum @jbenet LGTU?

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    Brian Tiger Chow committed Nov 17, 2014
    1 Configuration menu
    Copy the full SHA
    356a2d7 View commit details
    Browse the repository at this point in the history

  5. deps(eventlog) no need to augment Logger 

    allow framework to add level to log so level can be applied when using
text formatter

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    Brian Tiger Chow committed Nov 17, 2014
    Configuration menu
    Copy the full SHA
    884d629 View commit details
    Browse the repository at this point in the history

  6. refactor(eventlog) use polite formatter as a direct dependency 

    License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    Brian Tiger Chow committed Nov 17, 2014
    Configuration menu
    Copy the full SHA
    ddb0189 View commit details
    Browse the repository at this point in the history

  7. fix(core) tear-down leveldb 

    @jbenet @whyrusleeping @mappum

If we permit initialization in `ipfs daemon`, then we must ensure that
the node instantiated in `ipfs init` (to create the welcome file) shuts
down and releases resources.

Kept running into "resource temporarily unavailable". Discovered that it
was our cousins Jeff and Sanjay over at LevelDB Ave.

go-datastore doesn't expose Close() so I extended the TsDs interface and
submitted a patch.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

Signed-off-by: Brian Tiger Chow <brian.holderchow@gmail.com>
    Brian Tiger Chow committed Nov 17, 2014
    Configuration menu
    Copy the full SHA
    f26388e View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2014

  1. feat(util) add datastore Closer Wrapper 

    @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    bacf3ec View commit details
    Browse the repository at this point in the history

  2. feat(eventlog) initialize event logger with silent defaults 

    License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    aba4b2b View commit details
    Browse the repository at this point in the history

  3. debug(2/ipfs) make cmdDetails loggable 

    License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

# TYPES
# feat
# fix
# docs
# style (formatting, missing semi colons, etc; no code change):
# refactor
# test (adding missing tests, refactoring tests; no production code change)
# chore (updating grunt tasks etc; no production code change)

Signed-off-by: Brian Tiger Chow <brian.holderchow@gmail.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    81f5d6f View commit details
    Browse the repository at this point in the history

  4. refactor(2/init) extract const 

    License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

# TYPES
# feat
# fix
# docs
# style (formatting, missing semi colons, etc; no code change):
# refactor
# test (adding missing tests, refactoring tests; no production code change)
# chore (updating grunt tasks etc; no production code change)

Signed-off-by: Brian Tiger Chow <brian.holderchow@gmail.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    c883f7d View commit details
    Browse the repository at this point in the history

  5. refactor(2/init) use util.FileExists 

    License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

# TYPES
# feat
# fix
# docs
# style (formatting, missing semi colons, etc; no code change):
# refactor
# test (adding missing tests, refactoring tests; no production code change)
# chore (updating grunt tasks etc; no production code change)

Signed-off-by: Brian Tiger Chow <brian.holderchow@gmail.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    6a380ff View commit details
    Browse the repository at this point in the history

  6. feat(2/init) expose init with defaults 

    will support daemon initialization

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

# TYPES
# feat
# fix
# docs
# style (formatting, missing semi colons, etc; no code change):
# refactor
# test (adding missing tests, refactoring tests; no production code change)
# chore (updating grunt tasks etc; no production code change)

Signed-off-by: Brian Tiger Chow <brian.holderchow@gmail.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    d0a3f9b View commit details
    Browse the repository at this point in the history

  7. debug(core, datastore, daemon) wrap errors 

    @jbenet @whyrusleeping @mappum

very helpful for tracking down errors. the stack traces are only
shown when debug mode is visible. They function best when caught at the
source.

I propose we use this errors package as a drop-in replacement for
fmt.Errorf and errors.New in all of our code, and use errors.Wrap for
external errors as they emerge from others' libraries.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

Signed-off-by: Brian Tiger Chow <brian.holderchow@gmail.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    2bbfe4d View commit details
    Browse the repository at this point in the history

  8. feat(2/daemon) --initialized 

    @jbenet

now, ipfs can be built and executed in one step:
```
docker run jbenet/go-ipfs daemon --initialized
```

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    0612004 View commit details
    Browse the repository at this point in the history

  9. docs(eventlog/formatter) 

    @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    94bfc81 View commit details
    Browse the repository at this point in the history

  10. fix(2/daemon) initialized --> init 

    @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    bc39661 View commit details
    Browse the repository at this point in the history

  11. revert to debug error 

    @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    ef65bb1 View commit details
    Browse the repository at this point in the history

  12. doc(eventlog) init 

    @jbenet

yeah, these are just sane defaults

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    84354c7 View commit details
    Browse the repository at this point in the history

  13. docs(Dockerfile) update docker 'run' example 

    License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    cc02471 View commit details
    Browse the repository at this point in the history

  14. delegate teardown 

    this is silly but whatever

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    24f0fa0 View commit details
    Browse the repository at this point in the history

  15. inline prints 

    looking forward to fixing these again

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    7cebc3c View commit details
    Browse the repository at this point in the history

  16. fix 

    License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    8d4c216 View commit details
    Browse the repository at this point in the history

  17. test: test init output

    @jbenet
    jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    493e5d3 View commit details
    Browse the repository at this point in the history

  18. test: cat test actual output

    @jbenet
    jbenet committed Nov 18, 2014
    3 Configuration menu
    Copy the full SHA
    088016c View commit details
    Browse the repository at this point in the history

  19. fix node context (tests pass)

    @jbenet
    jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    d93e49e View commit details
    Browse the repository at this point in the history

  20. bugfix: node teardown is the last man to go down 

    Warning: during normal execution node teardown must be the
last thing that happens because command requests return
io.Readers, which may still be constructing or processing
their output. The node (and its subservices) is needed for
this. good night and good luck.
    @jbenet
    jbenet committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    eba0599 View commit details
    Browse the repository at this point in the history