Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring naming conventions #37

Merged
merged 3 commits into from
Sep 10, 2014
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions daemon/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,25 @@ type DaemonListener struct {
closed bool
}

func NewDaemonListener(node *core.IpfsNode, addr string) (*DaemonListener, error) {
type Command struct {
Command string
Args []string
Opts map[string]interface{}
}

func NewDaemonListener(Ipfsnode *core.IpfsNode, addr string) (*DaemonListener, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instance variables lower case

list, err := net.Listen("tcp", addr)
if err != nil {
return nil, err
}
fmt.Println("new daemon listener.")
fmt.Println("New daemon listener initialized.")

return &DaemonListener{
node: node,
node: Ipfsnode,
list: list,
}, nil
}

type Command struct {
Command string
Args []string
Opts map[string]interface{}
}

func NewCommand() *Command {
return &Command{
Opts: make(map[string]interface{}),
Expand All @@ -49,35 +49,35 @@ func NewCommand() *Command {
func (dl *DaemonListener) Listen() {
fmt.Println("listen.")
for {
c, err := dl.list.Accept()
conn, err := dl.list.Accept()
fmt.Println("Loop!")
if err != nil {
if !dl.closed {
u.PErr("DaemonListener Accept: %v\n", err)
}
return
}
go dl.handleConnection(c)
go dl.handleConnection(conn)
}
}

func (dl *DaemonListener) handleConnection(c net.Conn) {
defer c.Close()
func (dl *DaemonListener) handleConnection(conn net.Conn) {
defer conn.Close()

dec := json.NewDecoder(c)
dec := json.NewDecoder(conn)

var com Command
err := dec.Decode(&com)
var command Command
err := dec.Decode(&command)
if err != nil {
fmt.Fprintln(c, err)
fmt.Fprintln(conn, err)
return
}

u.DOut("Got command: %v\n", com)
ExecuteCommand(&com, dl.node, c)
u.DOut("Got command: %v\n", command)
ExecuteCommand(&command, dl.node, conn)
}

func ExecuteCommand(com *Command, n *core.IpfsNode, out io.Writer) {
func ExecuteCommand(com *Command, Ipfsnode *core.IpfsNode, out io.Writer) {
u.DOut("executing command: %s\n", com.Command)
switch com.Command {
case "add":
Expand All @@ -86,21 +86,21 @@ func ExecuteCommand(com *Command, n *core.IpfsNode, out io.Writer) {
depth = -1
}
for _, path := range com.Args {
_, err := commands.AddPath(n, path, depth)
_, err := commands.AddPath(Ipfsnode, path, depth)
if err != nil {
fmt.Fprintf(out, "addFile error: %v\n", err)
continue
}
}
case "cat":
for _, fn := range com.Args {
nd, err := n.Resolver.ResolvePath(fn)
DAGnode, err := Ipfsnode.Resolver.ResolvePath(fn)
if err != nil {
fmt.Fprintf(out, "catFile error: %v\n", err)
return
}

read, err := dag.NewDagReader(nd, n.DAG)
read, err := dag.NewDagReader(nd, Ipfsnode.DAG)
if err != nil {
fmt.Fprintln(out, err)
continue
Expand All @@ -114,9 +114,9 @@ func ExecuteCommand(com *Command, n *core.IpfsNode, out io.Writer) {
}
case "ls":
for _, fn := range com.Args {
nd, err := n.Resolver.ResolvePath(fn)
DAGnode, err := n.Resolver.ResolvePath(fn)
if err != nil {
fmt.Fprintf(out, "ls: %v\n", err)
fmt.Fprintf(out, "ls error: %v\n", err)
return
}

Expand All @@ -126,13 +126,13 @@ func ExecuteCommand(com *Command, n *core.IpfsNode, out io.Writer) {
}
case "pin":
for _, fn := range com.Args {
nd, err := n.Resolver.ResolvePath(fn)
DAGnode, err := Ipfsnode.Resolver.ResolvePath(fn)
if err != nil {
fmt.Fprintf(out, "pin: %v\n", err)
fmt.Fprintf(out, "pin error: %v\n", err)
return
}

err = n.PinDagNode(nd)
err = Ipfsnode.PinDagNode(nd)
if err != nil {
fmt.Fprintf(out, "pin: %v\n", err)
return
Expand Down
16 changes: 10 additions & 6 deletions daemon/daemon_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,26 @@ import (
"io"
"net"
"os"
"time"
"time"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run go fmt on save :)

)

func SendCommand(com *Command, server string) error {
con, err := net.DialTimeout("tcp", server, time.Millisecond*300)

//connects to the address on the network with a timeout and encodes the connection into JSON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run go lint (--> this comment should start with "SendCommand ...")

func SendCommand(command *Command, server string) error {

conn, err := net.DialTimeout("tcp", server, time.Millisecond*300)

if err != nil {
return err
}

enc := json.NewEncoder(con)
err = enc.Encode(com)
enc := json.NewEncoder(conn)
err = enc.Encode(command)
if err != nil {
return err
}

io.Copy(os.Stdout, con)
io.Copy(os.Stdout, conn)

return nil
}