Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues.
daemon --init breaks eventlog configuration
Introducing daemon --init broke eventlog configuration. Here's why:
Since the daemon doesn't require a repo/config and configureLogger only runs if the upcoming command uses the config/repo, logs are not configured before running the daemon.
Notice that the one actual requirement for the hook is the existence of a config/repo.
Therefore, we may want to simply check this property directly. Thoughts?
runtime logging system is not configured upon initialization
Now, after initialization, we apply the config.Log settings to the logging system. This ensures logging works when the daemon is started using
daemon --init
Third, this paves the way for the
repo
package described in #376.