Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bitswap:message) add wrapper for proto #41

Merged
merged 1 commit into from
Sep 11, 2014

Conversation

btc
Copy link
Contributor

@btc btc commented Sep 11, 2014

This PR adds a wrapper for the Proto.

Design Goals:

  • allow bitswap subsystem to deal with keys and blocks rather than strings and bytes
  • centralize message packaging logic
  • reduce conceptual overhead in large bitswap methods

@btc btc force-pushed the feat/bitswap-message-wrapper branch from 367217b to 421fe5b Compare September 11, 2014 10:27
@whyrusleeping
Copy link
Member

i like this type of refactor.

@btc
Copy link
Contributor Author

btc commented Sep 11, 2014

@whyrusleeping plenty more on the way!

(I'm keeping the PRs small and manageable)

@jbenet merge?

@jbenet
Copy link
Member

jbenet commented Sep 11, 2014

@perfmode Yep, LGTM!

btc pushed a commit that referenced this pull request Sep 11, 2014
refactor(bitswap:message) add wrapper for proto
@btc btc merged commit c370fc5 into master Sep 11, 2014
@btc btc deleted the feat/bitswap-message-wrapper branch September 11, 2014 18:09
ribasushi pushed a commit that referenced this pull request Jul 4, 2021
rename the protobuf to loggabletracer
longfeiWan9 pushed a commit to longfeiWan9/go-ipfs that referenced this pull request Nov 18, 2021
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Apr 7, 2022
fix inconsistent EnumerateChildrenAsync behavior
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants