-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WebUI version #4449
Update WebUI version #4449
Conversation
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's still really flaky (need to constantly reload to get things working) but seems to work better than it did before.
@Stebalien, despite the Connections page, where are you having issues? 😄 |
I think it was just lag introduced by the connections page. That is, I'd open the connections page and then try to switch to the Home page and it wouldn't show anything (although, on further testing, it's just really slow). I also couldn't get it to create a directory in the Files page on my first try but I can't reproduce that. |
@Stebalien yeah, the Conns page is very laggy and buggy. I really want to change that as you know. |
@hacdias hrm... either it doesnt work in firefox, or it doesnt work with the ipfs-companion extension. I get the following error message: |
Do you not get that second error with the current WebUI? IIRC, the companion redirects any URL starting with However, I can confirm that the connections page is broken on Firefox. Here's a stacktrace (FWIW, the JS is compressed).
|
@Stebalien strange... every page is working on my computer on Firefox. (I'm using |
@Stebalien double check to see if you were using the latest released go-ipfs |
Yup, its is the same issues as described in ipfs/ipfs-companion#291 Workaround for now: replace |
Thanks @lidel! |
Also, thank you @hacdias for all the fixes :) |
It was a pleasure! |
Woooooot! :D |
It's because I've disabled webgl in Firefox (it's a large attack surface). Nevermind. (ipfs/ipfs-webui#320) |
😄 |
That ^ /cc @diasdavid