-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grandcentral Routing (temporary while DHT is shown to be correct) #454
Conversation
Whats this? |
Ah! So this is a dht alternative using a central server to pull information from? |
@whyrusleeping this is a temporary routing system that we're putting in place so we can demo things correctly without depending on the dht (which does not work reliably,robustly, and permanently yet). We were demoing things last night and things weren't working well (e.g. not resolving properly), discussed this late last night (sorry, live, not on irc), and decided to use this so we can separate the concerns. |
oh alright, I was really confused, lol |
@whyrusleeping sorry-- should've posted something here / on irc. (i guess this is that message? >.< ) |
@@ -27,7 +27,8 @@ import ( | |||
peer "github.com/jbenet/go-ipfs/peer" | |||
pin "github.com/jbenet/go-ipfs/pin" | |||
routing "github.com/jbenet/go-ipfs/routing" | |||
dht "github.com/jbenet/go-ipfs/routing/dht" | |||
tracker "github.com/jbenet/go-ipfs/routing/tracker" | |||
trackerproxy "github.com/jbenet/go-ipfs/routing/tracker/proxy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not call this tracker. tracker has specific connotations in p2p (namely BT trackers), which is related but significantly different. Let's call it "delegated" routing (you route through whatever the delegate says)
4e66825
to
c530d66
Compare
@briantigerchow is this still ongoing? dht seems to be better off now, but i'd like to see some large (thousands of nodes) tests before really relying on it. |
c530d66
to
8e8da82
Compare
@jbenet This is ready for some initial testing |
bbcd7d0
to
34476e0
Compare
5060cc6
to
f1d94bf
Compare
868bf10
to
0a0793c
Compare
2d27326
to
bbcc824
Compare
@jbenet removed the stray |
@briantigerchow changes lgtm, thank you. |
Everything LGTM! let me know how you want to proceed with this merge. My constraints are:
|
Feel free to merge. The servers are already running. Users Pass flag "--routing=supernode" to turn it on. |
We're getting that fault panic on tip a lot. |
Fault panic on tip? |
@briantigerchow Yeah, on the jenkins "golang tip" build, we keep seeing this really weird fault, that we arent sure the cause of |
Grandcentral Routing (temporary while DHT is shown to be correct)
Make the Routing Table's latency tolerance configurable.
@jbenet @mappum @whyrusleeping
TODOs
extract databasecreate datastoreBackend
fromgrandcentral.Server