Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grandcentral Routing (temporary while DHT is shown to be correct) #454

Merged
merged 74 commits into from
Feb 16, 2015

Conversation

btc
Copy link
Contributor

@btc btc commented Dec 16, 2014

@jbenet @mappum @whyrusleeping

TODOs

  • pick a serialization format for provider records. perhaps just proto message
  • extract database Backend from grandcentral.Server create datastore
  • pass config value (server | client) in from UX
  • pick a peer/address/host for remote routing server
  • finally, make this test pass: https://build.protocol-dev.com/job/ipfs-network-test-add-cat/

@btc btc added the status/in-progress In progress label Dec 16, 2014
@whyrusleeping
Copy link
Member

Whats this?

@btc btc changed the title GrandCentral Routing Routing with a Tracker Dec 16, 2014
@whyrusleeping
Copy link
Member

Ah! So this is a dht alternative using a central server to pull information from?

@jbenet
Copy link
Member

jbenet commented Dec 16, 2014

@whyrusleeping this is a temporary routing system that we're putting in place so we can demo things correctly without depending on the dht (which does not work reliably,robustly, and permanently yet). We were demoing things last night and things weren't working well (e.g. not resolving properly), discussed this late last night (sorry, live, not on irc), and decided to use this so we can separate the concerns.

@whyrusleeping
Copy link
Member

oh alright, I was really confused, lol

@jbenet
Copy link
Member

jbenet commented Dec 16, 2014

@whyrusleeping sorry-- should've posted something here / on irc. (i guess this is that message? >.< )

@jbenet jbenet changed the title Routing with a Tracker Delegated Routing (temporary while dht is shown to be correct) Dec 16, 2014
@@ -27,7 +27,8 @@ import (
peer "github.com/jbenet/go-ipfs/peer"
pin "github.com/jbenet/go-ipfs/pin"
routing "github.com/jbenet/go-ipfs/routing"
dht "github.com/jbenet/go-ipfs/routing/dht"
tracker "github.com/jbenet/go-ipfs/routing/tracker"
trackerproxy "github.com/jbenet/go-ipfs/routing/tracker/proxy"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not call this tracker. tracker has specific connotations in p2p (namely BT trackers), which is related but significantly different. Let's call it "delegated" routing (you route through whatever the delegate says)

@btc btc self-assigned this Dec 18, 2014
@btc btc force-pushed the feat/grandcentral-routing branch 2 times, most recently from 4e66825 to c530d66 Compare December 21, 2014 07:17
@jbenet
Copy link
Member

jbenet commented Jan 5, 2015

@briantigerchow is this still ongoing? dht seems to be better off now, but i'd like to see some large (thousands of nodes) tests before really relying on it.

@btc btc force-pushed the feat/grandcentral-routing branch from c530d66 to 8e8da82 Compare January 28, 2015 12:52
@btc
Copy link
Contributor Author

btc commented Jan 28, 2015

@jbenet This is ready for some initial testing

@jbenet jbenet force-pushed the feat/grandcentral-routing branch from bbcd7d0 to 34476e0 Compare January 28, 2015 14:41
@btc btc force-pushed the feat/grandcentral-routing branch 6 times, most recently from 5060cc6 to f1d94bf Compare January 30, 2015 16:36
@btc btc changed the title Delegated Routing (temporary while dht is shown to be correct) Grandcentral Routing (temporary while DHT is shown to be correct) Jan 30, 2015
@btc btc force-pushed the feat/grandcentral-routing branch 3 times, most recently from 868bf10 to 0a0793c Compare January 30, 2015 23:37
@btc btc force-pushed the feat/grandcentral-routing branch from 2d27326 to bbcc824 Compare February 15, 2015 12:50
@btc
Copy link
Contributor Author

btc commented Feb 15, 2015

@jbenet removed the stray .go-ipfs dir and rebased/erased it out of the git history. declared the s3 datastore as thread safe. used the bootstrap strings from the config package.

@jbenet
Copy link
Member

jbenet commented Feb 16, 2015

@briantigerchow changes lgtm, thank you.

@jbenet
Copy link
Member

jbenet commented Feb 16, 2015

Everything LGTM! let me know how you want to proceed with this merge. My constraints are:

  • trivial to manage
  • easy for users to know how to switch between dht/snr (this could be just an example or a note in the readme we can point them to)
  • we should not enable it by default until we're certain it is better than dht. (i.e. run it alongside for a while and we can play with it?). We could become certain of this after a few hours of trying it out

@btc
Copy link
Contributor Author

btc commented Feb 16, 2015

Feel free to merge. The servers are already running. Users Pass flag "--routing=supernode" to turn it on.

@whyrusleeping
Copy link
Member

We're getting that fault panic on tip a lot.

@btc
Copy link
Contributor Author

btc commented Feb 16, 2015

Fault panic on tip?

@whyrusleeping
Copy link
Member

@briantigerchow Yeah, on the jenkins "golang tip" build, we keep seeing this really weird fault, that we arent sure the cause of

jbenet added a commit that referenced this pull request Feb 16, 2015
Grandcentral Routing (temporary while DHT is shown to be correct)
@jbenet jbenet merged commit 4778219 into master Feb 16, 2015
@jbenet jbenet removed the status/in-progress In progress label Feb 16, 2015
@jbenet jbenet deleted the feat/grandcentral-routing branch February 16, 2015 11:08
@btc btc removed their assignment Mar 30, 2015
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
Make the Routing Table's latency tolerance configurable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants