coreapi: Pin API #4575
Merged
coreapi: Pin API #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
51 tasks
frrist
reviewed
Jan 18, 2018
| t.Error(err) | ||
| } | ||
|
|
||
| err = api.Pin().Add(ctx, p) |
There was a problem hiding this comment.
Should be verify the content was pined? e.g. list, err = api.Pin().Ls(ctx) && len(list) == 1 as is done elsewhere?
There was a problem hiding this comment.
This is more of an example rather than a test, since this is tested a few times below I skipped that check here.
frrist
approved these changes
Jan 22, 2018
magik6k
force-pushed
the
feat/coreapi/pin
branch
from
2ea75a1
to
10e16a5
Compare
whyrusleeping
approved these changes
Jan 30, 2018
magik6k
force-pushed
the
feat/coreapi/pin
branch
from
10e16a5
to
896cc37
Compare
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
magik6k
force-pushed
the
feat/coreapi/pin
branch
from
896cc37
to
242c98f
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: