Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gx: update go-log #4974

Closed
wants to merge 1 commit into from
Closed

gx: update go-log #4974

wants to merge 1 commit into from

Conversation

djdv
Copy link
Contributor

@djdv djdv commented Apr 24, 2018

We still have components that use the old log though:

updating go-log to version 1.4.1 (QmTG23dvpBCBjqQwyDxV8CQT6jmS4PSftNr1VqHhE3MLy7)
dep go-libp2p-secio also imports go-log (QmRb5jh8z2E8hMGN2tkvs1yHynUanqnZ3UeKwgN1i9P1F8) (1.4.0)
dep go-libp2p/go-tcp-transport/go-reuseport also imports go-log (QmSpJByNKFX1sCsHBEp3R73FL4NF6FnQTEGyNAXHm2GS52) (1.2.0)

These need updating as well for
#2124 and #3068 to be fully resolved.

License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
@djdv djdv requested a review from Kubuxu as a code owner April 24, 2018 15:28
@ghost ghost assigned djdv Apr 24, 2018
@ghost ghost added the status/in-progress In progress label Apr 24, 2018
@whyrusleeping
Copy link
Member

This is going to have to wait for a libp2p update. Having different versions of the log package at different points in the tree is no bueno

@whyrusleeping
Copy link
Member

@djdv can you go through the tree and make sure the subpackages (in libp2p) all have go-log updated correctly? that libp2p update i mentioned is getting ready to happen, and it would be great for this all to go through at the same time

@Stebalien
Copy link
Member

The go-log update was included in #5007. go-log is now consistently 1.4.1 (QmTG23dvpBCBjqQwyDxV8CQT6jmS4PSftNr1VqHhE3MLy7)

@Stebalien Stebalien closed this Jun 3, 2018
@ghost ghost removed the status/in-progress In progress label Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants