refactor(bitswap) internal notifications #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 11, 2014 16:38
use a third-party pubsub library for internal communications Insights: * Within bitswap, the actors don't need anything more than simple pubsub behavior. Wrapping and unwrapping messages proves unneccessary. Changes: * Simplifies the interface for both actors calling GetBlock and actors receiving blocks on the network * Leverages a well-tested third-party pubsub library Design Goals: * reduce complexity * extract implementation details (wrapping and unwrapping data, etc) from bitswap and let bitswap focus on composition of core algorithms operations
|
In the framework introduced by https://github.com/jbenet/go-ipfs/tree/net, GetBlock is implemented synchronously. There's no need for communication between a handler and a caller. The async behavior is an implementation detail of net/service/SendRequest interface. recall:
Closing this for now. |
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…/libp2p/go-libp2p-core-0.2.3 Bump github.com/libp2p/go-libp2p-core from 0.2.2 to 0.2.3
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…dules/github.com/libp2p/go-libp2p-core-0.2.3 Bump github.com/libp2p/go-libp2p-core from 0.2.2 to 0.2.3
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Apr 7, 2022
Migrate dagutils from go-ipfs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whyrusleeping @jbenet
Context: In the bitswap subsystem, local actors block in
GetBlockwaiting on a message from the network. When results are received, a different actor receives the value and must dispatch to all waiting subcribers. If within the deadline, theGetBlocksubscriber receives the retrieved value.This PR introduces a simplified interface for this internal communication.
Insights:
behavior. Wrapping and unwrapping messages proves unnecessary.
Changes:
receiving blocks on the network
Design Goals:
from bitswap and let bitswap focus on composition of operations