Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use go 1.10 on jenkins #5009

Merged
merged 1 commit into from
May 17, 2018
Merged

ci: Use go 1.10 on jenkins #5009

merged 1 commit into from
May 17, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented May 9, 2018

whyrusleeping/tar-utils#2 uses strings.Builder for windows paths, it's a go 1.10 feature.

@magik6k magik6k requested a review from Kubuxu as a code owner May 9, 2018 18:54
@ghost ghost assigned magik6k May 9, 2018
@ghost ghost added the status/in-progress In progress label May 9, 2018
@magik6k magik6k force-pushed the misc/ci/go-1.10 branch from 069add8 to f3602e9 Compare May 9, 2018 18:54
@djdv
Copy link
Contributor

djdv commented May 9, 2018

Don't mind me, just breaking all the builds. 🙃

@magik6k magik6k mentioned this pull request May 9, 2018
Merged
@magik6k
Copy link
Member Author

magik6k commented May 9, 2018 •
edited
Loading

Requires adding the new go version in jenkins - ipfs-inactive/jenkins#113

cc @victorbjelkholm

@ghost ghost assigned victorb May 10, 2018
@victorb
Copy link
Member

victorb commented May 10, 2018

@magik6k I've deployed the jenkins changes and also made the pipeline here in go-ipfs to be more specific about which version it uses.

@victorb victorb removed their assignment May 10, 2018
@Mr0grog
Copy link
Contributor

Mr0grog commented May 11, 2018

The README mentions Go 1.9 in a couple places (https://github.com/ipfs/go-ipfs/blob/master/README.md#install-go, https://github.com/ipfs/go-ipfs/blob/master/README.md#troubleshooting). We should probably update those here, too, right?

@magik6k
Copy link
Member Author

magik6k commented May 11, 2018

Looks like it needs gx-go dist built with go 1.10.2.. https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/PR-5009/8/pipeline/15

@magik6k magik6k mentioned this pull request May 11, 2018
Closed
@ghost ghost assigned Stebalien May 12, 2018
@Stebalien
Copy link
Member

We'll need to rerun this when DNS has been updated to point to the latest go dists.

@Stebalien Stebalien force-pushed the misc/ci/go-1.10 branch 4 times, most recently from 775a357 to 103d078 Compare May 15, 2018 17:03
@Stebalien Stebalien added RFM and removed status/in-progress In progress labels May 15, 2018
@Kubuxu
Copy link
Member

Kubuxu commented May 16, 2018

A commit squash would be appreciated.

@magik6k @Stebalien
switch minimum go version to go 1.10
22a25ef 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Signed-off-by: Victor Bjelkholm <git@victor.earth>
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost added the status/in-progress In progress label May 16, 2018
@Stebalien Stebalien removed the status/in-progress In progress label May 16, 2018
@Stebalien Stebalien merged commit 139d624 into master May 17, 2018
@Stebalien Stebalien deleted the misc/ci/go-1.10 branch May 17, 2018 19:51
@Stebalien
Copy link
Member

Stebalien commented May 17, 2018 •
edited
Loading

emp

@djdv djdv mentioned this pull request May 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees

@Stebalien Stebalien

@magik6k magik6k

Labels
RFM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@magik6k @djdv @victorb @Mr0grog @Stebalien @Kubuxu