Add Docker step to Pre-Release Checklist #5043
Conversation
| @@ -28,6 +28,7 @@ will be allowed up to release day. | |||
| - [ ] publish dist.ipfs.io | |||
| - [ ] publish next version to https://github.com/ipfs/npm-go-ipfs | |||
| - [ ] publish gx version with `gx release`, as per [gx release guidelines](https://github.com/whyrusleeping/gx#publishing-and-releasing) | |||
| - [ ] publish image to [Docker Hub](https://hub.docker.com/r/ipfs/go-ipfs/tags/) and update `latest` and `release` tags to point at it | |||
There was a problem hiding this comment.
The publish should be automatic, but I think it takes a while. We should build image on one machine but then just update the tags.
I think we can setup the automatic build in Docker Hub to be automatic and tag images based on branches... That way, we can have a release branch that would point to the release tag in Docker Hub, and you'll only need to update that and push it to update the Docker Hub tags.
There was a problem hiding this comment.
While we are at this: are we able to update or.. remove the latest tag?
IMO it is too ambiguous, and keeping release and master may be a better idea.
Alternatively it should be automated to point at the same things as release
There was a problem hiding this comment.
latest is de-facto (or maybe just is) standard in Docker-land, so we should probably keep it. Having latest being in sync with release I think is what we've agreed before and would map best to how things usually are dealt with. master would be the "nightly" basically with all the latest changes.
Suggested in #3999 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
|
what is actually involved in publishing an image to dockerhub? updating the release branch on the repo is already part of the process (i just forget sometimes :/ ) |
|
As @whyrusleeping said, Dockerhub has been configured to build and tag the docker images when the master and release branches change on the go-ipfs repo. The intergration is currerntly broken, pending reconnecting github and dockerhub, but that'll get fixed. The releaser doesn't have to perform any extra steps, so I'm gonna close this out. |
Suggested in #3999 (comment) to avoid problem described in #3999 (comment)
cc @whyrusleeping @victorbjelkholm